| Message ID | 20231106144335.v2.6.I909b7c4453d7b7fb0db4b6e49aa21666279d827d@changeid (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 48d5cf4772ec6268853158d9ffc54612e988ebe6 |
| Headers | show |
| Series | [v2,1/9] arm64: dts: qcom: sc7180: Make watchdog bark interrupt edge triggered | expand |
On Mon, 6 Nov 2023 at 23:44, Douglas Anderson <dianders@chromium.org> wrote: > > As described in the patch ("arm64: dts: qcom: sc7180: Make watchdog > bark interrupt edge triggered"), the Qualcomm watchdog timer's bark > interrupt should be configured as edge triggered. Make the change. > > Fixes: 09b701b89a76 ("arm64: dts: qcom: sa8775p: add the watchdog node") > Reviewed-by: Guenter Roeck <linux@roeck-us.net> > Reviewed-by: Stephen Boyd <swboyd@chromium.org> > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- > > (no changes since v1) > > arch/arm64/boot/dts/qcom/sa8775p.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > index 13dd44dd9ed1..6b92f9083104 100644 > --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi > +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > @@ -2235,7 +2235,7 @@ watchdog@17c10000 { > compatible = "qcom,apss-wdt-sa8775p", "qcom,kpss-wdt"; > reg = <0x0 0x17c10000 0x0 0x1000>; > clocks = <&sleep_clk>; > - interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>; > + interrupts = <GIC_SPI 0 IRQ_TYPE_EDGE_RISING>; > }; > > memtimer: timer@17c20000 { > -- > 2.42.0.869.gea05f2083d-goog > Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi index 13dd44dd9ed1..6b92f9083104 100644 --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi @@ -2235,7 +2235,7 @@ watchdog@17c10000 { compatible = "qcom,apss-wdt-sa8775p", "qcom,kpss-wdt"; reg = <0x0 0x17c10000 0x0 0x1000>; clocks = <&sleep_clk>; - interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <GIC_SPI 0 IRQ_TYPE_EDGE_RISING>; }; memtimer: timer@17c20000 {
As described in the patch ("arm64: dts: qcom: sc7180: Make watchdog bark interrupt edge triggered"), the Qualcomm watchdog timer's bark interrupt should be configured as edge triggered. Make the change. Fixes: 09b701b89a76 ("arm64: dts: qcom: sa8775p: add the watchdog node") Reviewed-by: Guenter Roeck <linux@roeck-us.net> Reviewed-by: Stephen Boyd <swboyd@chromium.org> Signed-off-by: Douglas Anderson <dianders@chromium.org> --- (no changes since v1) arch/arm64/boot/dts/qcom/sa8775p.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)