| Message ID | 20231107111413.2212942-1-dmitry.baryshkov@linaro.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | drm/msm: remove exra drm_kms_helper_poll_init() call | expand |
On 11/7/2023 3:14 AM, Dmitry Baryshkov wrote: > It seems during rebases I have left a call to drm_kms_helper_poll_init() > which is not guarded by the (priv->kms_init) check. This leads to the > crash for the boards which don't have KMS output. Drop this call, as > there is a correctly guarded one next to the one being removed. > > Fixes: 506efcba3129 ("drm/msm: carve out KMS code from msm_drv.c") > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
On Tue, 07 Nov 2023 13:14:13 +0200, Dmitry Baryshkov wrote: > It seems during rebases I have left a call to drm_kms_helper_poll_init() > which is not guarded by the (priv->kms_init) check. This leads to the > crash for the boards which don't have KMS output. Drop this call, as > there is a correctly guarded one next to the one being removed. > > Applied, thanks! [1/1] drm/msm: remove exra drm_kms_helper_poll_init() call https://gitlab.freedesktop.org/drm/msm/-/commit/3944e343e54b Best regards,
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index 2aae7d107f33..3f217b578293 100644 --- a/drivers/gpu/drm/msm/msm_drv.c +++ b/drivers/gpu/drm/msm/msm_drv.c @@ -288,8 +288,6 @@ static int msm_drm_init(struct device *dev, const struct drm_driver *drv) if (ret) goto err_msm_uninit; - drm_kms_helper_poll_init(ddev); - if (priv->kms_init) { drm_kms_helper_poll_init(ddev); msm_fbdev_setup(ddev);
It seems during rebases I have left a call to drm_kms_helper_poll_init() which is not guarded by the (priv->kms_init) check. This leads to the crash for the boards which don't have KMS output. Drop this call, as there is a correctly guarded one next to the one being removed. Fixes: 506efcba3129 ("drm/msm: carve out KMS code from msm_drv.c") Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- drivers/gpu/drm/msm/msm_drv.c | 2 -- 1 file changed, 2 deletions(-)