| Message ID | 20231111094645.12520-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | arm64: dts: qcom: Revert "arm64: dts: qcom: qrb5165-rb5: enable DP altmode" | expand |
On 11/11/2023 10:46, Krzysztof Kozlowski wrote: > This reverts commit b3dea914127e9065df003002ed13a2ef40d19877. > > The commit introduced unsupported and undocumented properties: > > qrb5165-rb5.dtb: pmic@2: typec@1500:connector: 'altmodes' does not match any of the regexes: 'pinctrl-[0-9]+' > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> I forgot to Cc Dmitry, author of reverted commit. I bounced the original email to him and Cc-ing him here as well. Best regards, Krzysztof
On Sat, 11 Nov 2023 at 11:46, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > This reverts commit b3dea914127e9065df003002ed13a2ef40d19877. > > The commit introduced unsupported and undocumented properties: > > qrb5165-rb5.dtb: pmic@2: typec@1500:connector: 'altmodes' does not match any of the regexes: 'pinctrl-[0-9]+' We need this property to enable DP altmode on RB5. It has been parsed by the typec subsystem since the commit 7b458a4c5d73 ("usb: typec: Add typec_port_register_altmodes()"), merged in April 2021. Rather than landing this commit, let me propose to send the proper binding instead. If we can not agree on a compatible bindings document within the sensible timeframe (e.g. 1 month), I'm fine with dropping of the altmodes from qrb5156-rb5. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts > index c8cd40a462a3..3bd0c06e7315 100644 > --- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts > +++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts > @@ -1423,13 +1423,6 @@ PDO_FIXED_DUAL_ROLE | > PDO_FIXED_USB_COMM | > PDO_FIXED_DATA_SWAP)>; > > - altmodes { > - displayport { > - svid = <0xff01>; > - vdo = <0x00001c46>; > - }; > - }; > - > ports { > #address-cells = <1>; > #size-cells = <0>; > -- > 2.34.1 > >
On 11.11.2023 10:46, Krzysztof Kozlowski wrote: > This reverts commit b3dea914127e9065df003002ed13a2ef40d19877. > > The commit introduced unsupported and undocumented properties: > > qrb5165-rb5.dtb: pmic@2: typec@1500:connector: 'altmodes' does not match any of the regexes: 'pinctrl-[0-9]+' > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
On 13.11.2023 11:09, Dmitry Baryshkov wrote: > On Sat, 11 Nov 2023 at 11:46, Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >> This reverts commit b3dea914127e9065df003002ed13a2ef40d19877. >> >> The commit introduced unsupported and undocumented properties: >> >> qrb5165-rb5.dtb: pmic@2: typec@1500:connector: 'altmodes' does not match any of the regexes: 'pinctrl-[0-9]+' > > We need this property to enable DP altmode on RB5. It has been parsed > by the typec subsystem since the commit 7b458a4c5d73 ("usb: typec: Add > typec_port_register_altmodes()"), merged in April 2021. > > Rather than landing this commit, let me propose to send the proper > binding instead. If we can not agree on a compatible bindings document > within the sensible timeframe (e.g. 1 month), I'm fine with dropping > of the altmodes from qrb5156-rb5. Right, I'dve imagined this was taken care of.. Retain my r-b but have what Dmitry said in mind.. Konrad
On 13/11/2023 11:09, Dmitry Baryshkov wrote: > On Sat, 11 Nov 2023 at 11:46, Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >> This reverts commit b3dea914127e9065df003002ed13a2ef40d19877. >> >> The commit introduced unsupported and undocumented properties: >> >> qrb5165-rb5.dtb: pmic@2: typec@1500:connector: 'altmodes' does not match any of the regexes: 'pinctrl-[0-9]+' > > We need this property to enable DP altmode on RB5. It has been parsed > by the typec subsystem since the commit 7b458a4c5d73 ("usb: typec: Add > typec_port_register_altmodes()"), merged in April 2021. > > Rather than landing this commit, let me propose to send the proper > binding instead. If we can not agree on a compatible bindings document > within the sensible timeframe (e.g. 1 month), I'm fine with dropping > of the altmodes from qrb5156-rb5. I agree, sounds good for me. I just want to stir the pot and have the issue resolved :) Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts index c8cd40a462a3..3bd0c06e7315 100644 --- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts +++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts @@ -1423,13 +1423,6 @@ PDO_FIXED_DUAL_ROLE | PDO_FIXED_USB_COMM | PDO_FIXED_DATA_SWAP)>; - altmodes { - displayport { - svid = <0xff01>; - vdo = <0x00001c46>; - }; - }; - ports { #address-cells = <1>; #size-cells = <0>;
This reverts commit b3dea914127e9065df003002ed13a2ef40d19877. The commit introduced unsupported and undocumented properties: qrb5165-rb5.dtb: pmic@2: typec@1500:connector: 'altmodes' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 7 ------- 1 file changed, 7 deletions(-)