| Message ID | 20231120164331.8116-8-johan+linaro@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | de3b3de30999106549da4df88a7963d0ac02b91e |
| Headers | show |
| Series | ARM/arm64: dts: qcom: fix USB wakeup interrupt types | expand |
On Mon, Nov 20, 2023 at 05:43:27PM +0100, Johan Hovold wrote: > The DP/DM wakeup interrupts are edge triggered and which edge to trigger > on depends on use-case and whether a Low speed or Full/High speed device > is connected. > > Fixes: 07c8ded6e373 ("arm64: dts: qcom: add sdm670 and pixel 3a device trees") > Cc: stable@vger.kernel.org # 6.2 > Cc: Richard Acayan <mailingradian@gmail.com> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > --- Acked-by: Richard Acayan <mailingradian@gmail.com> > arch/arm64/boot/dts/qcom/sdm670.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm670.dtsi b/arch/arm64/boot/dts/qcom/sdm670.dtsi > index ba2043d67370..c873560ae9d5 100644 > --- a/arch/arm64/boot/dts/qcom/sdm670.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm670.dtsi > @@ -1297,8 +1297,8 @@ usb_1: usb@a6f8800 { > > interrupts = <GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 486 IRQ_TYPE_LEVEL_HIGH>, > - <GIC_SPI 488 IRQ_TYPE_LEVEL_HIGH>, > - <GIC_SPI 489 IRQ_TYPE_LEVEL_HIGH>; > + <GIC_SPI 488 IRQ_TYPE_EDGE_BOTH>, > + <GIC_SPI 489 IRQ_TYPE_EDGE_BOTH>; > interrupt-names = "hs_phy_irq", "ss_phy_irq", > "dm_hs_phy_irq", "dp_hs_phy_irq"; > > -- > 2.41.0 >
diff --git a/arch/arm64/boot/dts/qcom/sdm670.dtsi b/arch/arm64/boot/dts/qcom/sdm670.dtsi index ba2043d67370..c873560ae9d5 100644 --- a/arch/arm64/boot/dts/qcom/sdm670.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm670.dtsi @@ -1297,8 +1297,8 @@ usb_1: usb@a6f8800 { interrupts = <GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 486 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 488 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 489 IRQ_TYPE_LEVEL_HIGH>; + <GIC_SPI 488 IRQ_TYPE_EDGE_BOTH>, + <GIC_SPI 489 IRQ_TYPE_EDGE_BOTH>; interrupt-names = "hs_phy_irq", "ss_phy_irq", "dm_hs_phy_irq", "dp_hs_phy_irq";
The DP/DM wakeup interrupts are edge triggered and which edge to trigger on depends on use-case and whether a Low speed or Full/High speed device is connected. Fixes: 07c8ded6e373 ("arm64: dts: qcom: add sdm670 and pixel 3a device trees") Cc: stable@vger.kernel.org # 6.2 Cc: Richard Acayan <mailingradian@gmail.com> Signed-off-by: Johan Hovold <johan+linaro@kernel.org> --- arch/arm64/boot/dts/qcom/sdm670.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)