| Message ID | 20231204-qcom-aw2013-vio-v1-1-5d264bb5c0b2@gerhold.net (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | cc1ec484f2d0f464ad11b56fe3de2589c23f73ec |
| Headers | show |
| Series | arm64: dts: qcom: Add missing vio-supply for AW2013 | expand |
On Mon, 04 Dec 2023 10:46:11 +0100, Stephan Gerhold wrote: > Add the missing vio-supply to all usages of the AW2013 LED controller > to ensure that the regulator needed for pull-up of the interrupt and > I2C lines is really turned on. While this seems to have worked fine so > far some of these regulators are not guaranteed to be always-on. For > example, pm8916_l6 is typically turned off together with the display > if there aren't any other devices (e.g. sensors) keeping it always-on. > > [...] Applied, thanks! [1/1] arm64: dts: qcom: Add missing vio-supply for AW2013 commit: cc1ec484f2d0f464ad11b56fe3de2589c23f73ec Best regards,
diff --git a/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts b/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts index 37fa55166918..5f24c40a6020 100644 --- a/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts +++ b/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts @@ -104,6 +104,7 @@ led-controller@45 { #size-cells = <0>; vcc-supply = <&pm8916_l17>; + vio-supply = <&pm8916_l6>; led@0 { reg = <0>; diff --git a/arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dts b/arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dts index d4b88c787e59..510b3b3c4e3c 100644 --- a/arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dts +++ b/arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dts @@ -142,6 +142,7 @@ led-controller@45 { #size-cells = <0>; vcc-supply = <&pm8916_l16>; + vio-supply = <&pm8916_l5>; led@0 { reg = <0>; diff --git a/arch/arm64/boot/dts/qcom/msm8953-xiaomi-mido.dts b/arch/arm64/boot/dts/qcom/msm8953-xiaomi-mido.dts index ed95d09cedb1..6b9245cd8b0c 100644 --- a/arch/arm64/boot/dts/qcom/msm8953-xiaomi-mido.dts +++ b/arch/arm64/boot/dts/qcom/msm8953-xiaomi-mido.dts @@ -111,6 +111,7 @@ led-controller@45 { reg = <0x45>; vcc-supply = <&pm8953_l10>; + vio-supply = <&pm8953_l5>; #address-cells = <1>; #size-cells = <0>; diff --git a/arch/arm64/boot/dts/qcom/msm8953-xiaomi-tissot.dts b/arch/arm64/boot/dts/qcom/msm8953-xiaomi-tissot.dts index 61ff629c9bf3..9ac4f507e321 100644 --- a/arch/arm64/boot/dts/qcom/msm8953-xiaomi-tissot.dts +++ b/arch/arm64/boot/dts/qcom/msm8953-xiaomi-tissot.dts @@ -104,6 +104,7 @@ led-controller@45 { reg = <0x45>; vcc-supply = <&pm8953_l10>; + vio-supply = <&pm8953_l5>; #address-cells = <1>; #size-cells = <0>; diff --git a/arch/arm64/boot/dts/qcom/msm8953-xiaomi-vince.dts b/arch/arm64/boot/dts/qcom/msm8953-xiaomi-vince.dts index 1a1d3f92a511..b0588f30f8f1 100644 --- a/arch/arm64/boot/dts/qcom/msm8953-xiaomi-vince.dts +++ b/arch/arm64/boot/dts/qcom/msm8953-xiaomi-vince.dts @@ -113,6 +113,7 @@ led-controller@45 { reg = <0x45>; vcc-supply = <&pm8953_l10>; + vio-supply = <&pm8953_l5>; #address-cells = <1>; #size-cells = <0>;
Add the missing vio-supply to all usages of the AW2013 LED controller to ensure that the regulator needed for pull-up of the interrupt and I2C lines is really turned on. While this seems to have worked fine so far some of these regulators are not guaranteed to be always-on. For example, pm8916_l6 is typically turned off together with the display if there aren't any other devices (e.g. sensors) keeping it always-on. Cc: <stable@vger.kernel.org> # 6.6 Signed-off-by: Stephan Gerhold <stephan@gerhold.net> --- I omitted the Fixes: tag here as it would be 5 separate commits, and it's really only useful to backport this to v6.6+ since this is where the necessary driver addition landed (see commit baca986e1f2c3 ("leds: aw2013: Enable pull-up supply for interrupt and I2C"). I'm not aware that anyone actually ran into trouble with this missing regulator yet. --- arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts | 1 + arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dts | 1 + arch/arm64/boot/dts/qcom/msm8953-xiaomi-mido.dts | 1 + arch/arm64/boot/dts/qcom/msm8953-xiaomi-tissot.dts | 1 + arch/arm64/boot/dts/qcom/msm8953-xiaomi-vince.dts | 1 + 5 files changed, 5 insertions(+) --- base-commit: adcad44bd1c73a5264bff525e334e2f6fc01bb9b change-id: 20231204-qcom-aw2013-vio-91dbc025c464 Best regards,