| Message ID | 20231211080153.3005122-2-quic_jsuraj@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Ethernet DWMAC5 fault IRQ support | expand |
On Mon, Dec 11, 2023 at 01:31:51PM +0530, Suraj Jaiswal wrote: > Add binding doc for safety IRQ. The safety IRQ will be > triggered for ECC(error correction code), DPP(data path > parity), FSM(finite state machine) error. > > Signed-off-by: Suraj Jaiswal <quic_jsuraj@quicinc.com> Rob gave you his Reviewed-by over here on the last revision: https://lore.kernel.org/netdev/170206782161.2661547.16311911491075108498.robh@kernel.org/ in the future if someone gives you a tag you should add it to the patch for the next revision you send out (assuming you have to send out another version, otherwise the maintainers will collect the tags when they merge that version of the series). If the patches change a lot then it makes sense to remove the tag since it wasn't what they reviewed, but in this case you've only expanded a comment in the commit message so it is appropriate to be present. > --- > Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 9 ++++++--- > Documentation/devicetree/bindings/net/snps,dwmac.yaml | 6 ++++-- > 2 files changed, 10 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml > index 7bdb412a0185..93d21389e518 100644 > --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml > +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml > @@ -37,12 +37,14 @@ properties: > items: > - description: Combined signal for various interrupt events > - description: The interrupt that occurs when Rx exits the LPI state > + - description: The interrupt that occurs when HW safety error triggered > > interrupt-names: > minItems: 1 > items: > - const: macirq > - - const: eth_lpi > + - enum: [eth_lpi, safety] > + - const: safety > > clocks: > maxItems: 4 > @@ -89,8 +91,9 @@ examples: > <&gcc GCC_ETH_PTP_CLK>, > <&gcc GCC_ETH_RGMII_CLK>; > interrupts = <GIC_SPI 56 IRQ_TYPE_LEVEL_HIGH>, > - <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>; > - interrupt-names = "macirq", "eth_lpi"; > + <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 782 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "macirq", "eth_lpi", "safety"; > > rx-fifo-depth = <4096>; > tx-fifo-depth = <4096>; > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > index 5c2769dc689a..3b46d69ea97d 100644 > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > @@ -107,13 +107,15 @@ properties: > - description: Combined signal for various interrupt events > - description: The interrupt to manage the remote wake-up packet detection > - description: The interrupt that occurs when Rx exits the LPI state > + - description: The interrupt that occurs when HW safety error triggered > > interrupt-names: > minItems: 1 > items: > - const: macirq > - - enum: [eth_wake_irq, eth_lpi] > - - const: eth_lpi > + - enum: [eth_wake_irq, eth_lpi, safety] > + - enum: [eth_wake_irq, eth_lpi, safety] > + - enum: [eth_wake_irq, eth_lpi, safety] > > clocks: > minItems: 1 > -- > 2.25.1 >
sure @andrew Thanks Suraj On 12/11/2023 7:22 PM, Andrew Halaney wrote: > On Mon, Dec 11, 2023 at 01:31:51PM +0530, Suraj Jaiswal wrote: >> Add binding doc for safety IRQ. The safety IRQ will be >> triggered for ECC(error correction code), DPP(data path >> parity), FSM(finite state machine) error. >> >> Signed-off-by: Suraj Jaiswal <quic_jsuraj@quicinc.com> > > Rob gave you his Reviewed-by over here on the last revision: > > https://lore.kernel.org/netdev/170206782161.2661547.16311911491075108498.robh@kernel.org/ > > in the future if someone gives you a tag you should add it to the patch > for the next revision you send out (assuming you have to send out > another version, otherwise the maintainers will collect the tags when > they merge that version of the series). If the patches change a lot then > it makes sense to remove the tag since it wasn't what they reviewed, but > in this case you've only expanded a comment in the commit message so it is > appropriate to be present. > >> --- >> Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 9 ++++++--- >> Documentation/devicetree/bindings/net/snps,dwmac.yaml | 6 ++++-- >> 2 files changed, 10 insertions(+), 5 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml >> index 7bdb412a0185..93d21389e518 100644 >> --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml >> +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml >> @@ -37,12 +37,14 @@ properties: >> items: >> - description: Combined signal for various interrupt events >> - description: The interrupt that occurs when Rx exits the LPI state >> + - description: The interrupt that occurs when HW safety error triggered >> >> interrupt-names: >> minItems: 1 >> items: >> - const: macirq >> - - const: eth_lpi >> + - enum: [eth_lpi, safety] >> + - const: safety >> >> clocks: >> maxItems: 4 >> @@ -89,8 +91,9 @@ examples: >> <&gcc GCC_ETH_PTP_CLK>, >> <&gcc GCC_ETH_RGMII_CLK>; >> interrupts = <GIC_SPI 56 IRQ_TYPE_LEVEL_HIGH>, >> - <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>; >> - interrupt-names = "macirq", "eth_lpi"; >> + <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>, >> + <GIC_SPI 782 IRQ_TYPE_LEVEL_HIGH>; >> + interrupt-names = "macirq", "eth_lpi", "safety"; >> >> rx-fifo-depth = <4096>; >> tx-fifo-depth = <4096>; >> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml >> index 5c2769dc689a..3b46d69ea97d 100644 >> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml >> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml >> @@ -107,13 +107,15 @@ properties: >> - description: Combined signal for various interrupt events >> - description: The interrupt to manage the remote wake-up packet detection >> - description: The interrupt that occurs when Rx exits the LPI state >> + - description: The interrupt that occurs when HW safety error triggered >> >> interrupt-names: >> minItems: 1 >> items: >> - const: macirq >> - - enum: [eth_wake_irq, eth_lpi] >> - - const: eth_lpi >> + - enum: [eth_wake_irq, eth_lpi, safety] >> + - enum: [eth_wake_irq, eth_lpi, safety] >> + - enum: [eth_wake_irq, eth_lpi, safety] >> >> clocks: >> minItems: 1 >> -- >> 2.25.1 >> >
diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml index 7bdb412a0185..93d21389e518 100644 --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml @@ -37,12 +37,14 @@ properties: items: - description: Combined signal for various interrupt events - description: The interrupt that occurs when Rx exits the LPI state + - description: The interrupt that occurs when HW safety error triggered interrupt-names: minItems: 1 items: - const: macirq - - const: eth_lpi + - enum: [eth_lpi, safety] + - const: safety clocks: maxItems: 4 @@ -89,8 +91,9 @@ examples: <&gcc GCC_ETH_PTP_CLK>, <&gcc GCC_ETH_RGMII_CLK>; interrupts = <GIC_SPI 56 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>; - interrupt-names = "macirq", "eth_lpi"; + <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 782 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "macirq", "eth_lpi", "safety"; rx-fifo-depth = <4096>; tx-fifo-depth = <4096>; diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml index 5c2769dc689a..3b46d69ea97d 100644 --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml @@ -107,13 +107,15 @@ properties: - description: Combined signal for various interrupt events - description: The interrupt to manage the remote wake-up packet detection - description: The interrupt that occurs when Rx exits the LPI state + - description: The interrupt that occurs when HW safety error triggered interrupt-names: minItems: 1 items: - const: macirq - - enum: [eth_wake_irq, eth_lpi] - - const: eth_lpi + - enum: [eth_wake_irq, eth_lpi, safety] + - enum: [eth_wake_irq, eth_lpi, safety] + - enum: [eth_wake_irq, eth_lpi, safety] clocks: minItems: 1
Add binding doc for safety IRQ. The safety IRQ will be triggered for ECC(error correction code), DPP(data path parity), FSM(finite state machine) error. Signed-off-by: Suraj Jaiswal <quic_jsuraj@quicinc.com> --- Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 9 ++++++--- Documentation/devicetree/bindings/net/snps,dwmac.yaml | 6 ++++-- 2 files changed, 10 insertions(+), 5 deletions(-)