diff mbox series

arm64: dts: qcom: x1e80100-qcp: Fix supplies for some LDOs in PM8550

Message ID 20231218-x1e80100-qcp-dts-fix-pm8550-regulators-supplies-v1-1-0a313ce87745@linaro.org (mailing list archive)
State Accepted
Commit 49b0f4f141465b6446c0ade851ac11b13a888fa9
Headers show
Series arm64: dts: qcom: x1e80100-qcp: Fix supplies for some LDOs in PM8550 | expand

Commit Message

Abel Vesa Dec. 18, 2023, 4:36 p.m. UTC
The LDOs 1, 4 and 10 from PM8550 share the same supply, the SMPS 4
from PM8550ve. This needs to be done through shared supply approach
otherwise the parsing will fail. Also fix a bindings check failure.

Fixes: af16b00578a7 ("arm64: dts: qcom: Add base X1E80100 dtsi and the QCP dts")
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
Looks like I forgot to do the same thing for the QCP board.

Sorry about that.
---
 arch/arm64/boot/dts/qcom/x1e80100-qcp.dts | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)


---
base-commit: 48e8992e33abf054bcc0bb2e77b2d43bb899212e
change-id: 20231218-x1e80100-qcp-dts-fix-pm8550-regulators-supplies-03d1be3f026a

Best regards,

Comments

Krzysztof Kozlowski Dec. 18, 2023, 4:57 p.m. UTC | #1
On 18/12/2023 17:36, Abel Vesa wrote:
> The LDOs 1, 4 and 10 from PM8550 share the same supply, the SMPS 4
> from PM8550ve. This needs to be done through shared supply approach
> otherwise the parsing will fail. Also fix a bindings check failure.
> 
> Fixes: af16b00578a7 ("arm64: dts: qcom: Add base X1E80100 dtsi and the QCP dts")
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Bjorn Andersson Dec. 19, 2023, 7:33 p.m. UTC | #2
On Mon, 18 Dec 2023 18:36:40 +0200, Abel Vesa wrote:
> The LDOs 1, 4 and 10 from PM8550 share the same supply, the SMPS 4
> from PM8550ve. This needs to be done through shared supply approach
> otherwise the parsing will fail. Also fix a bindings check failure.
> 
> 

Applied, thanks!

[1/1] arm64: dts: qcom: x1e80100-qcp: Fix supplies for some LDOs in PM8550
      commit: 49b0f4f141465b6446c0ade851ac11b13a888fa9

Best regards,
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts b/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
index 3746e1de3623..a37ad9475c90 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
@@ -40,13 +40,11 @@  regulators-0 {
 
 		vdd-bob1-supply = <&vph_pwr>;
 		vdd-bob2-supply = <&vph_pwr>;
-		vdd-l1-supply = <&vreg_s4c_1p8>;
+		vdd-l1-l4-l10-supply = <&vreg_s4c_1p8>;
 		vdd-l2-l13-l14-supply = <&vreg_bob1>;
-		vdd-l4-supply = <&vreg_s4c_1p8>;
 		vdd-l5-l16-supply = <&vreg_bob1>;
 		vdd-l6-l7-supply = <&vreg_bob2>;
 		vdd-l8-l9-supply = <&vreg_bob1>;
-		vdd-l10-supply = <&vreg_s4c_1p8>;
 		vdd-l12-supply = <&vreg_s5j_1p2>;
 		vdd-l15-supply = <&vreg_s4c_1p8>;
 		vdd-l17-supply = <&vreg_bob2>;