| Message ID | 20240110151040.2155938-3-amadeus@jmu.edu.cn (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | arm64: dts: qcom: ipq8074: add MicroSD node | expand |
On 10/01/2024 16:10, Chukun Pan wrote: > Enable mmc device found on ipq6018 devices. > This node supports both eMMC and SD cards. > > Tested with: > eMMC (HS200) > SD Card (SDR50/SDR104) How? It is disabled... ... > + > + clocks = <&gcc GCC_SDCC1_AHB_CLK>, > + <&gcc GCC_SDCC1_APPS_CLK>, > + <&xo>; > + clock-names = "iface", "core", "xo"; > + resets = <&gcc GCC_SDCC1_BCR>; > + max-frequency = <192000000>; > + mmc-ddr-1_8v; > + mmc-hs200-1_8v; Aren't these three properties of the board? Best regards, Krzysztof
On 10/01/2024 16:10, Chukun Pan wrote: > Changes from v2: > * arm64: dts: qcom: ipq6018: add LDOA2 regulator > No Changes: > * arm64: dts: qcom: ipq8074: add MicroSD node I wrote it wrong in cover-letter, it's ipq6018, not ipq8074. No Changes: arm64: dts: qcom: ipq6018: enable sdhci node On 10/01/2024 16:22, Krzysztof wrote: > How? It is disabled... Disable it because not all devices have eMMC or MicroSD connected. I enabled it on the dts of the device and tested it on my ipq6000. > Aren't these three properties of the board? These are just general properties. Thanks, Chukun
On 11/01/2024 04:10, Chukun Pan wrote: > Disable it because not all devices have eMMC or MicroSD connected. > I enabled it on the dts of the device and tested it on my ipq6000. > >> Aren't these three properties of the board? > > These are just general properties. ? What is a general property? I repeat my question - these do not look SoC specific, but board. Best regards, Krzysztof
> ? What is a general property? I repeat my question - these do not look > SoC specific, but board. Sorry, I understood it wrong. I will remove the 1.8v properties in the next patch. Thanks, Chukun
diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi index 5e1277fea725..39fb38914a1e 100644 --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi @@ -436,6 +436,28 @@ dwc_1: usb@7000000 { }; }; + sdhc: mmc@7804000 { + compatible = "qcom,ipq6018-sdhci", "qcom,sdhci-msm-v5"; + reg = <0x0 0x7804000 0x0 0x1000>, + <0x0 0x7805000 0x0 0x1000>; + reg-names = "hc", "cqhci"; + + interrupts = <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 138 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "hc_irq", "pwr_irq"; + + clocks = <&gcc GCC_SDCC1_AHB_CLK>, + <&gcc GCC_SDCC1_APPS_CLK>, + <&xo>; + clock-names = "iface", "core", "xo"; + resets = <&gcc GCC_SDCC1_BCR>; + max-frequency = <192000000>; + mmc-ddr-1_8v; + mmc-hs200-1_8v; + + status = "disabled"; + }; + blsp_dma: dma-controller@7884000 { compatible = "qcom,bam-v1.7.0"; reg = <0x0 0x07884000 0x0 0x2b000>;
Enable mmc device found on ipq6018 devices. This node supports both eMMC and SD cards. Tested with: eMMC (HS200) SD Card (SDR50/SDR104) Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn> --- arch/arm64/boot/dts/qcom/ipq6018.dtsi | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+)