| Message ID | 20240121194221.13513-6-a39.skl@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | MSM8976 MDSS/GPU/WCNSS support | expand |
On 21/01/2024 20:41, Adam Skladowski wrote: > Adreno 506(MSM8953) and Adreno 510(MSM8976) require > Always-on branch clock to be enabled, describe it. > > Signed-off-by: Adam Skladowski <a39.skl@gmail.com> > --- > Documentation/devicetree/bindings/display/msm/gpu.yaml | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/msm/gpu.yaml b/Documentation/devicetree/bindings/display/msm/gpu.yaml > index b019db954793..9e36f54a5caf 100644 > --- a/Documentation/devicetree/bindings/display/msm/gpu.yaml > +++ b/Documentation/devicetree/bindings/display/msm/gpu.yaml > @@ -133,7 +133,7 @@ allOf: > properties: > clocks: > minItems: 2 > - maxItems: 7 > + maxItems: 8 I would prefer we start enforcing the order. The initial flexibility was because of conversion from the old bindings and dealing with some technical debt, AFAIU. This is requirement of new clock, so maybe better add dedicated if:then case which will be enforcing the order with always-on at the end. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/display/msm/gpu.yaml b/Documentation/devicetree/bindings/display/msm/gpu.yaml index b019db954793..9e36f54a5caf 100644 --- a/Documentation/devicetree/bindings/display/msm/gpu.yaml +++ b/Documentation/devicetree/bindings/display/msm/gpu.yaml @@ -133,7 +133,7 @@ allOf: properties: clocks: minItems: 2 - maxItems: 7 + maxItems: 8 clock-names: items: @@ -148,6 +148,8 @@ allOf: description: GPU Memory Interface clock - const: alt_mem_iface description: GPU Alternative Memory Interface clock + - const: alwayson + description: GPU Always-On clock - const: gfx3d description: GPU 3D engine clock - const: rbbmtimer @@ -155,7 +157,7 @@ allOf: - const: rbcpr description: GPU RB Core Power Reduction clock minItems: 2 - maxItems: 7 + maxItems: 8 required: - clocks
Adreno 506(MSM8953) and Adreno 510(MSM8976) require Always-on branch clock to be enabled, describe it. Signed-off-by: Adam Skladowski <a39.skl@gmail.com> --- Documentation/devicetree/bindings/display/msm/gpu.yaml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)