diff mbox series

[1/2] arm64: dts: qcom: sm8550: Add dma-coherent property

Message ID 20240125102413.3016-2-quic_lxu5@quicinc.com (mailing list archive)
State Accepted
Headers show
Series arm64: dts: qcom: Add dma-coherent property on | expand

Commit Message

Ling Xu Jan. 25, 2024, 10:24 a.m. UTC
Add dma-coherent property to fastRPC context bank nodes to pass dma
sequence test in fastrpc sanity test, ensure that data integrity is
maintained during DMA operations.

Signed-off-by: Ling Xu <quic_lxu5@quicinc.com>
---
 arch/arm64/boot/dts/qcom/sm8550.dtsi | 13 +++++++++++++
 1 file changed, 13 insertions(+)

Comments

Konrad Dybcio Jan. 25, 2024, 4:38 p.m. UTC | #1
On 1/25/24 11:24, Ling Xu wrote:
> Add dma-coherent property to fastRPC context bank nodes to pass dma
> sequence test in fastrpc sanity test, ensure that data integrity is
> maintained during DMA operations.
> 
> Signed-off-by: Ling Xu <quic_lxu5@quicinc.com>
> ---

How can we replicate this validation?

Konrad
Ling Xu Jan. 26, 2024, 2:34 a.m. UTC | #2
在 2024/1/26 0:38, Konrad Dybcio 写道:
> 
> 
> On 1/25/24 11:24, Ling Xu wrote:
>> Add dma-coherent property to fastRPC context bank nodes to pass dma
>> sequence test in fastrpc sanity test, ensure that data integrity is
>> maintained during DMA operations.
>>
>> Signed-off-by: Ling Xu <quic_lxu5@quicinc.com>
>> ---
> 
> How can we replicate this validation?
> 
> Konrad

Without this change, case8 and case14 about DMA sequence test in fastRPC sanity test can not pass.

The steps to do fastRPC sanity test is:
1.download code
p4 login
export PATH="$PATH:/prj/qct/asw/qctss/linux/bin/vce"
vce.py view --base fastrpctest.common.1.0 --checkout=<username> --root .
2.compile command
chmod -R 777 ./fastrpc_tests && python3 ./fastrpc_tests/build_fastrpc_test.py -target=LE
3.run fastRPC test
fastrpc_tests_ReleaseG_push_LE.bat
adb shell fastrpc_tests -e (case number) -d 3
Konrad Dybcio Feb. 1, 2024, 8:39 p.m. UTC | #3
On 26.01.2024 03:34, Ling Xu wrote:
> 在 2024/1/26 0:38, Konrad Dybcio 写道:
>>
>>
>> On 1/25/24 11:24, Ling Xu wrote:
>>> Add dma-coherent property to fastRPC context bank nodes to pass dma
>>> sequence test in fastrpc sanity test, ensure that data integrity is
>>> maintained during DMA operations.
>>>
>>> Signed-off-by: Ling Xu <quic_lxu5@quicinc.com>
>>> ---
>>
>> How can we replicate this validation?
>>
>> Konrad
> 
> Without this change, case8 and case14 about DMA sequence test in fastRPC sanity test can not pass.
> 
> The steps to do fastRPC sanity test is:
> 1.download code
> p4 login
> export PATH="$PATH:/prj/qct/asw/qctss/linux/bin/vce"
> vce.py view --base fastrpctest.common.1.0 --checkout=<username> --root .

I'm assuming it's not this one.. https://pypi.org/project/vce/


> 2.compile command
> chmod -R 777 ./fastrpc_tests && python3 ./fastrpc_tests/build_fastrpc_test.py -target=LE
> 3.run fastRPC test
> fastrpc_tests_ReleaseG_push_LE.bat
> adb shell fastrpc_tests -e (case number) -d 3
> 

I see, however there has been some talks about halting fastrpc developments
until an open source userspace counterpart is ready, as upstream outright
rejects binary glue..

That said, I am not sure whether I'd be against fixing up the devicetree
component..

Konrad
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
index ee1ba5a8c8fc..00bb803940fc 100644
--- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
@@ -4254,6 +4254,7 @@ 
 						reg = <3>;
 						iommus = <&apps_smmu 0x1003 0x80>,
 							 <&apps_smmu 0x1063 0x0>;
+						dma-coherent;
 					};
 
 					compute-cb@4 {
@@ -4261,6 +4262,7 @@ 
 						reg = <4>;
 						iommus = <&apps_smmu 0x1004 0x80>,
 							 <&apps_smmu 0x1064 0x0>;
+						dma-coherent;
 					};
 
 					compute-cb@5 {
@@ -4268,6 +4270,7 @@ 
 						reg = <5>;
 						iommus = <&apps_smmu 0x1005 0x80>,
 							 <&apps_smmu 0x1065 0x0>;
+						dma-coherent;
 					};
 
 					compute-cb@6 {
@@ -4275,6 +4278,7 @@ 
 						reg = <6>;
 						iommus = <&apps_smmu 0x1006 0x80>,
 							 <&apps_smmu 0x1066 0x0>;
+						dma-coherent;
 					};
 
 					compute-cb@7 {
@@ -4282,6 +4286,7 @@ 
 						reg = <7>;
 						iommus = <&apps_smmu 0x1007 0x80>,
 							 <&apps_smmu 0x1067 0x0>;
+						dma-coherent;
 					};
 				};
 
@@ -4388,6 +4393,7 @@ 
 						iommus = <&apps_smmu 0x1961 0x0>,
 							 <&apps_smmu 0x0c01 0x20>,
 							 <&apps_smmu 0x19c1 0x10>;
+						dma-coherent;
 					};
 
 					compute-cb@2 {
@@ -4396,6 +4402,7 @@ 
 						iommus = <&apps_smmu 0x1962 0x0>,
 							 <&apps_smmu 0x0c02 0x20>,
 							 <&apps_smmu 0x19c2 0x10>;
+						dma-coherent;
 					};
 
 					compute-cb@3 {
@@ -4404,6 +4411,7 @@ 
 						iommus = <&apps_smmu 0x1963 0x0>,
 							 <&apps_smmu 0x0c03 0x20>,
 							 <&apps_smmu 0x19c3 0x10>;
+						dma-coherent;
 					};
 
 					compute-cb@4 {
@@ -4412,6 +4420,7 @@ 
 						iommus = <&apps_smmu 0x1964 0x0>,
 							 <&apps_smmu 0x0c04 0x20>,
 							 <&apps_smmu 0x19c4 0x10>;
+						dma-coherent;
 					};
 
 					compute-cb@5 {
@@ -4420,6 +4429,7 @@ 
 						iommus = <&apps_smmu 0x1965 0x0>,
 							 <&apps_smmu 0x0c05 0x20>,
 							 <&apps_smmu 0x19c5 0x10>;
+						dma-coherent;
 					};
 
 					compute-cb@6 {
@@ -4428,6 +4438,7 @@ 
 						iommus = <&apps_smmu 0x1966 0x0>,
 							 <&apps_smmu 0x0c06 0x20>,
 							 <&apps_smmu 0x19c6 0x10>;
+						dma-coherent;
 					};
 
 					compute-cb@7 {
@@ -4436,6 +4447,7 @@ 
 						iommus = <&apps_smmu 0x1967 0x0>,
 							 <&apps_smmu 0x0c07 0x20>,
 							 <&apps_smmu 0x19c7 0x10>;
+						dma-coherent;
 					};
 
 					compute-cb@8 {
@@ -4444,6 +4456,7 @@ 
 						iommus = <&apps_smmu 0x1968 0x0>,
 							 <&apps_smmu 0x0c08 0x20>,
 							 <&apps_smmu 0x19c8 0x10>;
+						dma-coherent;
 					};
 
 					/* note: secure cb9 in downstream */