| Message ID | 20240130130132.9550-2-amadeus@jmu.edu.cn (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm64: dts: qcom: ipq6018: add sdhci node | expand |
On Tue, Jan 30, 2024 at 09:01:31PM +0800, Chukun Pan wrote: > Add LDOA2 regulator of MP5496 to support SDCC voltage scaling. > > Suggested-by: Robert Marko <robimarko@gmail.com> > Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn> > --- > arch/arm64/boot/dts/qcom/ipq6018.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi > index 5e1277fea725..322eced0b876 100644 > --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi > @@ -174,6 +174,11 @@ ipq6018_s2: s2 { > regulator-max-microvolt = <1062500>; > regulator-always-on; > }; > + > + ipq6018_l2: l2 { I still don't see a patch that does "something-supply = <&ipq6018_l2>;", which would imply that the main thing this patch achieves is that the regulator framework might turn the regulator off after a while. Shouldn't there be a user of ipq6018_l2? Regards, Bjorn > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <3300000>; > + }; > }; > }; > }; > -- > 2.25.1 >
Hi, Bjorn > I still don't see a patch that does "something-supply = <&ipq6018_l2>;", > which would imply that the main thing this patch achieves is that the > regulator framework might turn the regulator off after a while. > Shouldn't there be a user of ipq6018_l2? Although there is the sdhc node in ipq6018-cp01-c1 in the qsdk kernel, I don't have the official rdp board of qca, so I can't test it. Normally it looks like this: &sdhc { bus-width = <4>; cd-gpios = <&tlmm 62 GPIO_ACTIVE_LOW>; ... /* specific properties */ pinctrl-0 = <&sdhci_pins>; pinctrl-names = "default"; vqmmc-supply = <&ipq6018_l2>; status = "okay"; }; As for actual routers, there are users. One of the examples is on openwrt, a development board like 8devices: https://github.com/openwrt/openwrt/blob/main/target/linux/qualcommax/files/arch/arm64/boot/dts/qcom/ipq6010-mango-dvk.dts#L272 vqmmc-supply = <&ipq6018_l2>; cd-gpios = <&tlmm 62 GPIO_ACTIVE_LOW>; ... The function of this node is to reference sd/emmc supply for devices with pmic. Please let me know if it doesn't fit in this patch series and I will deal with this in another pmic patch series. Thanks, Chukun
diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi index 5e1277fea725..322eced0b876 100644 --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi @@ -174,6 +174,11 @@ ipq6018_s2: s2 { regulator-max-microvolt = <1062500>; regulator-always-on; }; + + ipq6018_l2: l2 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <3300000>; + }; }; }; };
Add LDOA2 regulator of MP5496 to support SDCC voltage scaling. Suggested-by: Robert Marko <robimarko@gmail.com> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn> --- arch/arm64/boot/dts/qcom/ipq6018.dtsi | 5 +++++ 1 file changed, 5 insertions(+)