| Message ID | 20240220-lm3630a-fixups-v1-4-9ca62f7e4a33@z3ntu.xyz (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Various fixes for the lm3630a backlight driver | expand |
On Tue, Feb 20, 2024 at 12:11:22AM +0100, Luca Weiss wrote: > Connect the panel with the backlight nodes so that the backlight can be > turned off when the display is blanked. > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> > --- > arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts b/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts > index 4aaae8537a3f..8eaa5b162815 100644 > --- a/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts > +++ b/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts > @@ -182,7 +182,7 @@ &blsp2_i2c5 { > status = "okay"; > clock-frequency = <355000>; > > - led-controller@38 { > + backlight: led-controller@38 { Again... a minor nit regarding existing problems but this node doesn't follow the generic naming recommendations: https://devicetree-specification.readthedocs.io/en/stable/devicetree-basics.html#generic-names-recommendation Daniel.
On Dienstag, 20. Februar 2024 15:12:10 CET Daniel Thompson wrote: > On Tue, Feb 20, 2024 at 12:11:22AM +0100, Luca Weiss wrote: > > Connect the panel with the backlight nodes so that the backlight can be > > turned off when the display is blanked. > > > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > > Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> > > > > --- > > arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts b/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts > > index 4aaae8537a3f..8eaa5b162815 100644 > > --- a/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts > > +++ b/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts > > @@ -182,7 +182,7 @@ &blsp2_i2c5 { > > status = "okay"; > > clock-frequency = <355000>; > > > > - led-controller@38 { > > + backlight: led-controller@38 { > > Again... a minor nit regarding existing problems but this node doesn't > follow the generic naming recommendations: > https://devicetree-specification.readthedocs.io/en/stable/devicetree-basics.html#generic-names-recommendation "led-controller" is listed on that page, or do you mean something else? > > > Daniel. >
On Tue, Feb 20, 2024 at 05:45:32PM +0100, Luca Weiss wrote: > On Dienstag, 20. Februar 2024 15:12:10 CET Daniel Thompson wrote: > > On Tue, Feb 20, 2024 at 12:11:22AM +0100, Luca Weiss wrote: > > > Connect the panel with the backlight nodes so that the backlight can be > > > turned off when the display is blanked. > > > > > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > > > > Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> > > > > > > > --- > > > arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts | 4 +++- > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts b/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts > > > index 4aaae8537a3f..8eaa5b162815 100644 > > > --- a/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts > > > +++ b/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts > > > @@ -182,7 +182,7 @@ &blsp2_i2c5 { > > > status = "okay"; > > > clock-frequency = <355000>; > > > > > > - led-controller@38 { > > > + backlight: led-controller@38 { > > > > Again... a minor nit regarding existing problems but this node doesn't > > follow the generic naming recommendations: > > https://devicetree-specification.readthedocs.io/en/stable/devicetree-basics.html#generic-names-recommendation > > "led-controller" is listed on that page, or do you mean something else? That's the point ;-). It is supposed to be called backlight@38! Daniel.
diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts b/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts index 4aaae8537a3f..8eaa5b162815 100644 --- a/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts +++ b/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts @@ -182,7 +182,7 @@ &blsp2_i2c5 { status = "okay"; clock-frequency = <355000>; - led-controller@38 { + backlight: led-controller@38 { compatible = "ti,lm3630a"; status = "okay"; reg = <0x38>; @@ -272,6 +272,8 @@ panel: panel@0 { reg = <0>; compatible = "lg,acx467akm-7"; + backlight = <&backlight>; + pinctrl-names = "default"; pinctrl-0 = <&panel_pin>;
Connect the panel with the backlight nodes so that the backlight can be turned off when the display is blanked. Signed-off-by: Luca Weiss <luca@z3ntu.xyz> --- arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)