| Message ID | 20240308-qcom_scm-is_err-check-v1-1-9c3e1ceefafe@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e6f3dac9cf11eff1daddeaa69521370c8941a5f9 |
| Headers | show |
| Series | firmware: qcom_scm: remove IS_ERR() checks from qcom_scm_bw_{en,dis}able() | expand |
On 8.03.2024 10:25, Gabor Juhos wrote: > Since the qcom_scm_probe() function returns with an error if > __scm->path contains an error pointer, it is not needed to > verify that again in the qcom_scm_bw_{en,dis}able() functions > so remove the superfluous IS_ERR() checks. > > Signed-off-by: Gabor Juhos <j4g8y7@gmail.com> > --- > Based on v6.8-rc7. > --- LGTM Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
On Fri, 08 Mar 2024 10:25:07 +0100, Gabor Juhos wrote: > Since the qcom_scm_probe() function returns with an error if > __scm->path contains an error pointer, it is not needed to > verify that again in the qcom_scm_bw_{en,dis}able() functions > so remove the superfluous IS_ERR() checks. > > Applied, thanks! [1/1] firmware: qcom_scm: remove IS_ERR() checks from qcom_scm_bw_{en,dis}able() commit: e6f3dac9cf11eff1daddeaa69521370c8941a5f9 Best regards,
diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c index 520de9b5633ab..a3bfe7de0bfd7 100644 --- a/drivers/firmware/qcom/qcom_scm.c +++ b/drivers/firmware/qcom/qcom_scm.c @@ -163,9 +163,6 @@ static int qcom_scm_bw_enable(void) if (!__scm->path) return 0; - if (IS_ERR(__scm->path)) - return -EINVAL; - mutex_lock(&__scm->scm_bw_lock); if (!__scm->scm_vote_count) { ret = icc_set_bw(__scm->path, 0, UINT_MAX); @@ -183,7 +180,7 @@ static int qcom_scm_bw_enable(void) static void qcom_scm_bw_disable(void) { - if (IS_ERR_OR_NULL(__scm->path)) + if (!__scm->path) return; mutex_lock(&__scm->scm_bw_lock);
Since the qcom_scm_probe() function returns with an error if __scm->path contains an error pointer, it is not needed to verify that again in the qcom_scm_bw_{en,dis}able() functions so remove the superfluous IS_ERR() checks. Signed-off-by: Gabor Juhos <j4g8y7@gmail.com> --- Based on v6.8-rc7. --- drivers/firmware/qcom/qcom_scm.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- base-commit: 90d35da658da8cff0d4ecbb5113f5fac9d00eb72 change-id: 20240308-qcom_scm-is_err-check-96a5cc6f17cf Best regards,