| Message ID | 20240320122515.3243711-1-caleb.connolly@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d73ed58d7f2793df161d0afb66afab3d1b862945 |
| Headers | show |
| Series | arm64: dts: qcom: sdm845-db845c: make pcie0_3p3v_dual always-on | expand |
On 3/20/24 13:25, Caleb Connolly wrote: > This regulator is responsible not just for the PCIe 3.3v rail, but also > for 5v VBUS on the left USB port. There is currently no way to correctly > model this dependency on the USB controller, as a result when the PCIe > driver is not available (for example when in the initramfs) USB is > non-functional. > > Until support is added for modelling this property (likely by > referencing it as a supply under a usb-connector node), let's just make > it always on. We don't target any power constrained usecases and this > regulator is required for USB to function correctly. > > Fixes: 3f72e2d3e682 ("arm64: dts: qcom: Add Dragonboard 845c") > Suggested-by: Bjorn Andersson <quic_bjorande@quicinc.com> > Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
On Wed, 20 Mar 2024 12:25:11 +0000, Caleb Connolly wrote: > This regulator is responsible not just for the PCIe 3.3v rail, but also > for 5v VBUS on the left USB port. There is currently no way to correctly > model this dependency on the USB controller, as a result when the PCIe > driver is not available (for example when in the initramfs) USB is > non-functional. > > Until support is added for modelling this property (likely by > referencing it as a supply under a usb-connector node), let's just make > it always on. We don't target any power constrained usecases and this > regulator is required for USB to function correctly. > > [...] Applied, thanks! [1/1] arm64: dts: qcom: sdm845-db845c: make pcie0_3p3v_dual always-on commit: d73ed58d7f2793df161d0afb66afab3d1b862945 Best regards,
diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts index 1f517328199b..9a74464b8af9 100644 --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts @@ -194,8 +194,14 @@ pcie0_3p3v_dual: vldo-3v3-regulator { regulator-max-microvolt = <3300000>; gpio = <&tlmm 90 GPIO_ACTIVE_HIGH>; enable-active-high; + /* + * FIXME: this regulator is responsible for VBUS on the left USB + * port. Keep it always on until we can correctly model this + * this relationship. + */ + regulator-always-on; pinctrl-names = "default"; pinctrl-0 = <&pcie0_pwren_state>; };
This regulator is responsible not just for the PCIe 3.3v rail, but also for 5v VBUS on the left USB port. There is currently no way to correctly model this dependency on the USB controller, as a result when the PCIe driver is not available (for example when in the initramfs) USB is non-functional. Until support is added for modelling this property (likely by referencing it as a supply under a usb-connector node), let's just make it always on. We don't target any power constrained usecases and this regulator is required for USB to function correctly. Fixes: 3f72e2d3e682 ("arm64: dts: qcom: Add Dragonboard 845c") Suggested-by: Bjorn Andersson <quic_bjorande@quicinc.com> Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org> --- arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 6 ++++++ 1 file changed, 6 insertions(+)