| Message ID | 20240320141136.26827-2-quic_depengs@quicinc.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | media: qcom: camss: Add sm8550 support | expand |
On 20/03/2024 14:11, Depeng Shao wrote: > From: Yongsheng Li <quic_yon@quicinc.com> > > Adds a CAMSS SoC identifier for the sm8550. > > Signed-off-by: Yongsheng Li <quic_yon@quicinc.com> > --- > drivers/media/platform/qcom/camss/camss.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/platform/qcom/camss/camss.h b/drivers/media/platform/qcom/camss/camss.h > index ac15fe23a702..2f63206a8463 100644 > --- a/drivers/media/platform/qcom/camss/camss.h > +++ b/drivers/media/platform/qcom/camss/camss.h > @@ -78,6 +78,7 @@ enum camss_version { > CAMSS_845, > CAMSS_8250, > CAMSS_8280XP, > + CAMSS_8550, > }; > > enum icc_count { Acked-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
On 20/03/2024 15:11, Depeng Shao wrote: > From: Yongsheng Li <quic_yon@quicinc.com> > > Adds a CAMSS SoC identifier for the sm8550. Why? > > Signed-off-by: Yongsheng Li <quic_yon@quicinc.com> > --- > drivers/media/platform/qcom/camss/camss.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/platform/qcom/camss/camss.h b/drivers/media/platform/qcom/camss/camss.h > index ac15fe23a702..2f63206a8463 100644 > --- a/drivers/media/platform/qcom/camss/camss.h > +++ b/drivers/media/platform/qcom/camss/camss.h > @@ -78,6 +78,7 @@ enum camss_version { > CAMSS_845, > CAMSS_8250, > CAMSS_8280XP, > + CAMSS_8550, > }; What is the point of this patch alone? What does it change? Why adding enum? In the next patch, are you going to add one line to some kerneldoc? Another patch, one function? Best regards, Krzysztof
On 20/03/2024 15:51, Krzysztof Kozlowski wrote: > On 20/03/2024 15:11, Depeng Shao wrote: >> From: Yongsheng Li <quic_yon@quicinc.com> >> >> Adds a CAMSS SoC identifier for the sm8550. > > Why? > >> >> Signed-off-by: Yongsheng Li <quic_yon@quicinc.com> >> --- >> drivers/media/platform/qcom/camss/camss.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/media/platform/qcom/camss/camss.h b/drivers/media/platform/qcom/camss/camss.h >> index ac15fe23a702..2f63206a8463 100644 >> --- a/drivers/media/platform/qcom/camss/camss.h >> +++ b/drivers/media/platform/qcom/camss/camss.h >> @@ -78,6 +78,7 @@ enum camss_version { >> CAMSS_845, >> CAMSS_8250, >> CAMSS_8280XP, >> + CAMSS_8550, >> }; > > What is the point of this patch alone? What does it change? Why adding > enum? In the next patch, are you going to add one line to some > kerneldoc? Another patch, one function? > > Best regards, > Krzysztof > Yeah true enough, you could also add this enum where you use it.. --- bod
On 20/03/2024 16:53, Bryan O'Donoghue wrote: > On 20/03/2024 15:51, Krzysztof Kozlowski wrote: >> On 20/03/2024 15:11, Depeng Shao wrote: >>> From: Yongsheng Li <quic_yon@quicinc.com> >>> >>> Adds a CAMSS SoC identifier for the sm8550. >> >> Why? >> >>> >>> Signed-off-by: Yongsheng Li <quic_yon@quicinc.com> >>> --- >>> drivers/media/platform/qcom/camss/camss.h | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/media/platform/qcom/camss/camss.h b/drivers/media/platform/qcom/camss/camss.h >>> index ac15fe23a702..2f63206a8463 100644 >>> --- a/drivers/media/platform/qcom/camss/camss.h >>> +++ b/drivers/media/platform/qcom/camss/camss.h >>> @@ -78,6 +78,7 @@ enum camss_version { >>> CAMSS_845, >>> CAMSS_8250, >>> CAMSS_8280XP, >>> + CAMSS_8550, >>> }; >> >> What is the point of this patch alone? What does it change? Why adding >> enum? In the next patch, are you going to add one line to some >> kerneldoc? Another patch, one function? >> >> Best regards, >> Krzysztof >> > > Yeah true enough, you could also add this enum where you use it.. Just to clarify my comment: this does not mean that entire patchset should be squashed into one patch, because that would be unmanageable. But your work should be organized in logical chunks, where some added code is being used. There is at least one more such change without immediate users in this patchset... Best regards, Krzysztof
diff --git a/drivers/media/platform/qcom/camss/camss.h b/drivers/media/platform/qcom/camss/camss.h index ac15fe23a702..2f63206a8463 100644 --- a/drivers/media/platform/qcom/camss/camss.h +++ b/drivers/media/platform/qcom/camss/camss.h @@ -78,6 +78,7 @@ enum camss_version { CAMSS_845, CAMSS_8250, CAMSS_8280XP, + CAMSS_8550, }; enum icc_count {