| Message ID | 20240322-typec-fix-sm8250-v1-1-1ac22b333ea9@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm64: dts: qcom: sm8250: fix description of the Type-C signals | expand |
On 22/03/2024 11:58, Dmitry Baryshkov wrote: > The OF graph should describe physical signals. There is no 'role switch' > signal between Type-C connector and the DWC3 USB controller. Instead > there is a HighSpeed signal lane between DWC3 controller and the USB-C > connector. Rename endpoints in accordance to that (this follows the > example lead by other plaforms, including QRB2210 RB1, QRB4210 RB2 and > all PMIC GLINK platforms). > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Hmm I think if you are going to change the name here, you should also do so here grep role_switch arch/arm64/* -r | wc -l 54 Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- bod
On Fri, 22 Mar 2024 at 14:03, Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote: > > On 22/03/2024 11:58, Dmitry Baryshkov wrote: > > The OF graph should describe physical signals. There is no 'role switch' > > signal between Type-C connector and the DWC3 USB controller. Instead > > there is a HighSpeed signal lane between DWC3 controller and the USB-C > > connector. Rename endpoints in accordance to that (this follows the > > example lead by other plaforms, including QRB2210 RB1, QRB4210 RB2 and > > all PMIC GLINK platforms). > > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > Hmm > > I think if you are going to change the name here, you should also do so here > > grep role_switch arch/arm64/* -r | wc -l > 54 Oh, my. I'll take a look at the qcom platforms for v2. And funny enough sc8180x even uses old bindings for the QMP PHY. > Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts index cd0db4f31d4a..44239d1e57e9 100644 --- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts +++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts @@ -1356,8 +1356,8 @@ &usb_1_dwc3 { usb-role-switch; }; -&usb_1_role_switch_out { - remote-endpoint = <&pm8150b_role_switch_in>; +&usb_1_dwc3_hs_out { + remote-endpoint = <&pm8150b_hs_in>; }; &usb_1_hsphy { @@ -1465,8 +1465,8 @@ ports { port@0 { reg = <0>; - pm8150b_role_switch_in: endpoint { - remote-endpoint = <&usb_1_role_switch_out>; + pm8150b_hs_in: endpoint { + remote-endpoint = <&usb_1_dwc3_hs_out>; }; }; diff --git a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi index 6f54f50a70b0..99915a2b97e2 100644 --- a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi @@ -652,8 +652,8 @@ ports { port@0 { reg = <0>; - pm8150b_role_switch_in: endpoint { - remote-endpoint = <&usb_1_role_switch_out>; + pm8150b_hs_in: endpoint { + remote-endpoint = <&usb_1_dwc3_hs_out>; }; }; }; @@ -716,8 +716,8 @@ &usb_1_hsphy { status = "okay"; }; -&usb_1_role_switch_out { - remote-endpoint = <&pm8150b_role_switch_in>; +&usb_1_dwc3_hs_out { + remote-endpoint = <&pm8150b_hs_in>; }; &ufs_mem_hc { diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi index 39bd8f0eba1e..d57039a4c3aa 100644 --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi @@ -4196,7 +4196,7 @@ usb_1_dwc3: usb@a600000 { phy-names = "usb2-phy", "usb3-phy"; port { - usb_1_role_switch_out: endpoint {}; + usb_1_dwc3_hs_out: endpoint {}; }; }; };
The OF graph should describe physical signals. There is no 'role switch' signal between Type-C connector and the DWC3 USB controller. Instead there is a HighSpeed signal lane between DWC3 controller and the USB-C connector. Rename endpoints in accordance to that (this follows the example lead by other plaforms, including QRB2210 RB1, QRB4210 RB2 and all PMIC GLINK platforms). Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 8 ++++---- arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi | 8 ++++---- arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 +- 3 files changed, 9 insertions(+), 9 deletions(-)