Message ID | 20240323032806.14356-1-yuehaibing@huawei.com (mailing list archive) |
---|---|
State | Accepted |
Commit | 551eb5194bf328652decc5531edd9c65a5d2a17c |
Headers | show |
Series | clk: qcom: Fix SM_GPUCC_8650 dependencies | expand |
On 23/03/2024 04:28, Yue Haibing wrote: > CONFIG_SM_GCC_8650 depends on ARM64 but it is selected by > CONFIG_SM_GPUCC_8650, which can be selected on ARM, resulting in a > Kconfig warning. > > WARNING: unmet direct dependencies detected for SM_GCC_8650 > Depends on [n]: COMMON_CLK [=y] && COMMON_CLK_QCOM [=y] && (ARM64 || COMPILE_TEST [=n]) > Selected by [m]: > - SM_GPUCC_8650 [=m] && COMMON_CLK [=y] && COMMON_CLK_QCOM [=y] > > Add the same dependencies to CONFIG_SM_GPUCC_8650 to resolve the warning. > > Fixes: 8676fd4f3874 ("clk: qcom: add the SM8650 GPU Clock Controller driver") > Signed-off-by: Yue Haibing <yuehaibing@huawei.com> > --- > drivers/clk/qcom/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig > index 8ab08e7b5b6c..3e85df1514bd 100644 > --- a/drivers/clk/qcom/Kconfig > +++ b/drivers/clk/qcom/Kconfig > @@ -1094,6 +1094,7 @@ config SM_GPUCC_8550 > > config SM_GPUCC_8650 > tristate "SM8650 Graphics Clock Controller" > + depends on ARM64 || COMPILE_TEST > select SM_GCC_8650 > help > Support for the graphics clock controller on SM8650 devices. Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Quoting Yue Haibing (2024-03-22 20:28:06) > CONFIG_SM_GCC_8650 depends on ARM64 but it is selected by > CONFIG_SM_GPUCC_8650, which can be selected on ARM, resulting in a > Kconfig warning. > > WARNING: unmet direct dependencies detected for SM_GCC_8650 > Depends on [n]: COMMON_CLK [=y] && COMMON_CLK_QCOM [=y] && (ARM64 || COMPILE_TEST [=n]) > Selected by [m]: > - SM_GPUCC_8650 [=m] && COMMON_CLK [=y] && COMMON_CLK_QCOM [=y] > > Add the same dependencies to CONFIG_SM_GPUCC_8650 to resolve the warning. > > Fixes: 8676fd4f3874 ("clk: qcom: add the SM8650 GPU Clock Controller driver") > Signed-off-by: Yue Haibing <yuehaibing@huawei.com> > --- This is superseded by https://lore.kernel.org/r/20240318-fix-some-qcom-kconfig-deps-v1-2-ea0773e3df5a@kernel.org Bjorn did you want me to pick that series up?
diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig index 8ab08e7b5b6c..3e85df1514bd 100644 --- a/drivers/clk/qcom/Kconfig +++ b/drivers/clk/qcom/Kconfig @@ -1094,6 +1094,7 @@ config SM_GPUCC_8550 config SM_GPUCC_8650 tristate "SM8650 Graphics Clock Controller" + depends on ARM64 || COMPILE_TEST select SM_GCC_8650 help Support for the graphics clock controller on SM8650 devices.
CONFIG_SM_GCC_8650 depends on ARM64 but it is selected by CONFIG_SM_GPUCC_8650, which can be selected on ARM, resulting in a Kconfig warning. WARNING: unmet direct dependencies detected for SM_GCC_8650 Depends on [n]: COMMON_CLK [=y] && COMMON_CLK_QCOM [=y] && (ARM64 || COMPILE_TEST [=n]) Selected by [m]: - SM_GPUCC_8650 [=m] && COMMON_CLK [=y] && COMMON_CLK_QCOM [=y] Add the same dependencies to CONFIG_SM_GPUCC_8650 to resolve the warning. Fixes: 8676fd4f3874 ("clk: qcom: add the SM8650 GPU Clock Controller driver") Signed-off-by: Yue Haibing <yuehaibing@huawei.com> --- drivers/clk/qcom/Kconfig | 1 + 1 file changed, 1 insertion(+)