| Message ID | 20240326141222.200452-2-raymondhackley@protonmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: qcom: msm8916/8216-samsung-fortuna: Add samsung,fortuna binding | expand |
On 26/03/2024 15:12, Raymond Hackley wrote: > Add common binding samsung,fortuna used by the following > Samsung Galaxy Grand Prime devices: > - SM-G530FZ (msm8916-samsung-grandprimelte) > - SM-G530H (msm8216-samsung-fortuna3g) > - SM-G530W (msm8916-gprimeltecan) > > Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com> > --- > arch/arm64/boot/dts/qcom/msm8216-samsung-fortuna3g.dts | 2 +- > arch/arm64/boot/dts/qcom/msm8916-samsung-gprimeltecan.dts | 2 +- > arch/arm64/boot/dts/qcom/msm8916-samsung-grandprimelte.dts | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8216-samsung-fortuna3g.dts b/arch/arm64/boot/dts/qcom/msm8216-samsung-fortuna3g.dts > index 366914be7d53..877fd2d7bb57 100644 > --- a/arch/arm64/boot/dts/qcom/msm8216-samsung-fortuna3g.dts > +++ b/arch/arm64/boot/dts/qcom/msm8216-samsung-fortuna3g.dts > @@ -6,6 +6,6 @@ > > / { > model = "Samsung Galaxy Grand Prime (SM-G530H)"; > - compatible = "samsung,fortuna3g", "qcom,msm8916"; > + compatible = "samsung,fortuna3g", "samsung,fortuna", "qcom,msm8916"; It does not look like you tested the DTS against bindings. Please run `make dtbs_check W=1` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ for instructions). Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/qcom/msm8216-samsung-fortuna3g.dts b/arch/arm64/boot/dts/qcom/msm8216-samsung-fortuna3g.dts index 366914be7d53..877fd2d7bb57 100644 --- a/arch/arm64/boot/dts/qcom/msm8216-samsung-fortuna3g.dts +++ b/arch/arm64/boot/dts/qcom/msm8216-samsung-fortuna3g.dts @@ -6,6 +6,6 @@ / { model = "Samsung Galaxy Grand Prime (SM-G530H)"; - compatible = "samsung,fortuna3g", "qcom,msm8916"; + compatible = "samsung,fortuna3g", "samsung,fortuna", "qcom,msm8916"; chassis-type = "handset"; }; diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-gprimeltecan.dts b/arch/arm64/boot/dts/qcom/msm8916-samsung-gprimeltecan.dts index 9d65fa58ba92..8c7d71e05da3 100644 --- a/arch/arm64/boot/dts/qcom/msm8916-samsung-gprimeltecan.dts +++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-gprimeltecan.dts @@ -6,7 +6,7 @@ / { model = "Samsung Galaxy Grand Prime (SM-G530W)"; - compatible = "samsung,gprimeltecan", "qcom,msm8916"; + compatible = "samsung,gprimeltecan", "samsung,fortuna", "qcom,msm8916"; chassis-type = "handset"; reserved-memory { diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-grandprimelte.dts b/arch/arm64/boot/dts/qcom/msm8916-samsung-grandprimelte.dts index a66ce4b13547..1781e04a25c9 100644 --- a/arch/arm64/boot/dts/qcom/msm8916-samsung-grandprimelte.dts +++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-grandprimelte.dts @@ -6,7 +6,7 @@ / { model = "Samsung Galaxy Grand Prime (SM-G530FZ)"; - compatible = "samsung,grandprimelte", "qcom,msm8916"; + compatible = "samsung,grandprimelte", "samsung,fortuna", "qcom,msm8916"; chassis-type = "handset"; };
Add common binding samsung,fortuna used by the following Samsung Galaxy Grand Prime devices: - SM-G530FZ (msm8916-samsung-grandprimelte) - SM-G530H (msm8216-samsung-fortuna3g) - SM-G530W (msm8916-gprimeltecan) Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com> --- arch/arm64/boot/dts/qcom/msm8216-samsung-fortuna3g.dts | 2 +- arch/arm64/boot/dts/qcom/msm8916-samsung-gprimeltecan.dts | 2 +- arch/arm64/boot/dts/qcom/msm8916-samsung-grandprimelte.dts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)