| Message ID | 20240328-dt-bindings-arm-qcom-add-support-for-samsung-galaxy-zfold5-v1-1-cb612e3ade18@yahoo.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | dt-bindings: arm: qcom: Add Samsung Galaxy Z Fold5 | expand |
On 28.03.2024 3:31 PM, Alexandru Marc Serdeliuc via B4 Relay wrote: > From: Alexandru Marc Serdeliuc <serdeliuk@yahoo.com> > > This documents Samsung Galaxy Z Fold5 (samsung,q5q) > which is a foldable phone by Samsung based on the sm8550 SoC. > > Signed-off-by: Alexandru Marc Serdeliuc <serdeliuk@yahoo.com> > --- > This documents Samsung Galaxy Z Fold5 (samsung,q5q) > which is a foldable phone by Samsung based on the sm8550 SoC. > --- That's very welcome, but are you going to submit a devicetree for it? Konrad
Hi Konrad, Thanks, yes, I am new to b4 and sending patches, in a few minutes I will add the second patch. That actually add the device tree, but without the previous patch it showed me a warning, and with both patches provided another warning that i need to split them in two. Best regards, Marc On 28/3/24 15:39, Konrad Dybcio wrote: > On 28.03.2024 3:31 PM, Alexandru Marc Serdeliuc via B4 Relay wrote: >> From: Alexandru Marc Serdeliuc <serdeliuk@yahoo.com> >> >> This documents Samsung Galaxy Z Fold5 (samsung,q5q) >> which is a foldable phone by Samsung based on the sm8550 SoC. >> >> Signed-off-by: Alexandru Marc Serdeliuc <serdeliuk@yahoo.com> >> --- >> This documents Samsung Galaxy Z Fold5 (samsung,q5q) >> which is a foldable phone by Samsung based on the sm8550 SoC. >> --- > That's very welcome, but are you going to submit a devicetree for it? > > Konrad
On 28.03.2024 3:42 PM, Alexandru Serdeliuc wrote: > Hi Konrad, > > > Thanks, yes, I am new to b4 and sending patches, in a few minutes I will add the second patch. > > That actually add the device tree, but without the previous patch it showed me a warning, and with both patches provided another warning that i need to split them in two. Oh no, you should send them together! Could you please paste the warning so that we can work out the issue? Konrad
Hi Konrad, Thanks, I unfortunately sent the patch 2 prior seeing your reply. The warning was this one which says that i need to send the mods separately in two patches: >>> >>>WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst >>> I suppose that me sending two separate patches was not good, how i can fix this? Best regards, Marc On 28/3/24 15:47, Konrad Dybcio wrote: > On 28.03.2024 3:42 PM, Alexandru Serdeliuc wrote: >> Hi Konrad, >> >> >> Thanks, yes, I am new to b4 and sending patches, in a few minutes I will add the second patch. >> >> That actually add the device tree, but without the previous patch it showed me a warning, and with both patches provided another warning that i need to split them in two. > Oh no, you should send them together! Could you please paste the warning so that > we can work out the issue? > > Konrad
On 28.03.2024 4:10 PM, Alexandru Serdeliuc wrote: > Hi Konrad, > > Thanks, I unfortunately sent the patch 2 prior seeing your reply. > > The warning was this one which says that i need to send the mods separately in two patches: > >>>> > >>>>WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst Hm, if they were two separate patches, this is a false-positive. Could you push the branch somewhere, so that we can report it to checkpatch maintainers? > >>>> > > > I suppose that me sending two separate patches was not good, how i can fix this? Please pick them both onto a single branch and send together as a series, with a revision bump (v2) and mention that you made no changes other than combining the two in the cover letter. Konrad
Is there anything I need to do to sent them as a series? Or only modify all 3 files on a new branch and send them as a new patch? The situation can be replicated easy, modify the following two files Documentation/devicetree/bindings/arm/qcom.yaml arch/arm64/boot/dts/qcom/Makefile Then generate the pach and check, will show this $ ./scripts/checkpatch.pl /tmp/tosend2/0001-arm64-dts-qcom-add-support-for-samsung-galaxy-z-fold5.eml WARNING: Missing commit description - Add an appropriate one WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #59: new file mode 100644 total: 0 errors, 3 warnings, 630 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. /tmp/tosend2/0001-arm64-dts-qcom-add-support-for-samsung-galaxy-z-fold5.eml has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. On 28/3/24 16:34, Konrad Dybcio wrote: > On 28.03.2024 4:10 PM, Alexandru Serdeliuc wrote: >> Hi Konrad, >> >> Thanks, I unfortunately sent the patch 2 prior seeing your reply. >> >> The warning was this one which says that i need to send the mods separately in two patches: >> >>>>> WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst > Hm, if they were two separate patches, this is a false-positive. Could you > push the branch somewhere, so that we can report it to checkpatch maintainers? > >> >> I suppose that me sending two separate patches was not good, how i can fix this? > Please pick them both onto a single branch and send together as a series, > with a revision bump (v2) and mention that you made no changes other than > combining the two in the cover letter. > > Konrad
On 28/03/2024 15:31, Alexandru Marc Serdeliuc via B4 Relay wrote: > From: Alexandru Marc Serdeliuc <serdeliuk@yahoo.com> > > This documents Samsung Galaxy Z Fold5 (samsung,q5q) > which is a foldable phone by Samsung based on the sm8550 SoC. > > Signed-off-by: Alexandru Marc Serdeliuc <serdeliuk@yahoo.com> > --- > This documents Samsung Galaxy Z Fold5 (samsung,q5q) > which is a foldable phone by Samsung based on the sm8550 SoC. Please always send DTS and its binding together. Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- This is an automated instruction, just in case, because many review tags are being ignored. If you know the process, you can skip it (please do not feel offended by me posting it here - no bad intentions intended). If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, under or above your Signed-off-by tag. Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply. https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml index 66beaac60e1d..dea2a23b8fc2 100644 --- a/Documentation/devicetree/bindings/arm/qcom.yaml +++ b/Documentation/devicetree/bindings/arm/qcom.yaml @@ -1003,6 +1003,7 @@ properties: - qcom,sm8550-hdk - qcom,sm8550-mtp - qcom,sm8550-qrd + - samsung,q5q - const: qcom,sm8550 - items: