| Message ID | 20240401-typec-fix-sm8250-v3-3-604dce3ad103@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: qcom: fix description of the Type-C signals | expand |
On 01/04/2024 21:33, Dmitry Baryshkov wrote: > Instead > there is a HighSpeed signal lane between DWC3 controller and the USB-C > connector. I still don't think this is an accurate statement. The upstream names and labels should be followed for consistency but role-switching and the DP/DN lines on the type-c port are not related. If you drop that sentence in your commit log, then add. Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
On Tue, 2 Apr 2024 at 12:42, Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote: > > On 01/04/2024 21:33, Dmitry Baryshkov wrote: > > Instead > > there is a HighSpeed signal lane between DWC3 controller and the USB-C > > connector. > > I still don't think this is an accurate statement. The upstream names > and labels should be followed for consistency but role-switching and the > DP/DN lines on the type-c port are not related. I fully agree with you. And that's why I'm replacing the labels. If you open the bindings for usb-c-connector and for the snps,dwc3 host, you will see that both bindings describe HS/SS ports. DWC3 also describes a single port for usb-data-role switching, which can be used instead of HS/SS ports, but usb-c-connector doesn't have this option.
On 1.04.2024 10:33 PM, Dmitry Baryshkov wrote: > The OF graph should describe physical signals. There is no 'role switch' > signal between Type-C connector and the DWC3 USB controller. Instead > there is a HighSpeed signal lane between DWC3 controller and the USB-C > connector. Rename endpoints in accordance to that (this follows the > example lead by other plaforms, including QRB2210 RB1, QRB4210 RB2 and > all PMIC GLINK platforms). > > Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- Hot discussions aside, this is consistent with bindings, so: Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts index cd0db4f31d4a..44239d1e57e9 100644 --- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts +++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts @@ -1356,8 +1356,8 @@ &usb_1_dwc3 { usb-role-switch; }; -&usb_1_role_switch_out { - remote-endpoint = <&pm8150b_role_switch_in>; +&usb_1_dwc3_hs_out { + remote-endpoint = <&pm8150b_hs_in>; }; &usb_1_hsphy { @@ -1465,8 +1465,8 @@ ports { port@0 { reg = <0>; - pm8150b_role_switch_in: endpoint { - remote-endpoint = <&usb_1_role_switch_out>; + pm8150b_hs_in: endpoint { + remote-endpoint = <&usb_1_dwc3_hs_out>; }; }; diff --git a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi index 2042020eb0dd..6cc0bcb40f1f 100644 --- a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi @@ -659,8 +659,8 @@ ports { port@0 { reg = <0>; - pm8150b_role_switch_in: endpoint { - remote-endpoint = <&usb_1_role_switch_out>; + pm8150b_hs_in: endpoint { + remote-endpoint = <&usb_1_dwc3_hs_out>; }; }; }; @@ -723,8 +723,8 @@ &usb_1_hsphy { status = "okay"; }; -&usb_1_role_switch_out { - remote-endpoint = <&pm8150b_role_switch_in>; +&usb_1_dwc3_hs_out { + remote-endpoint = <&pm8150b_hs_in>; }; &ufs_mem_hc { diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi index 7f2333c9d17d..440bbb89bf8a 100644 --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi @@ -4196,7 +4196,7 @@ usb_1_dwc3: usb@a600000 { phy-names = "usb2-phy", "usb3-phy"; port { - usb_1_role_switch_out: endpoint {}; + usb_1_dwc3_hs_out: endpoint {}; }; }; };