| Message ID | 20240412190310.1647893-2-volodymyr_babchuk@epam.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 5927bc586a3f2a81abcf8134fda5f7639abeeefd |
| Headers | show |
| Series | [v3,1/2] arm64: dts: qcom: sa8155p-adp: fix SDHC2 CD pin configuration | expand |
On Fri, Apr 12, 2024 at 07:03:26PM +0000, Volodymyr Babchuk wrote: > Voltage regulator L13C is used by SD card IO interface. In order to > support UHS modes, IO interface voltage needs to be set to 1.8V. This > patch extends minimum voltage range of L13C regulator to allow this. > I think this one also deserves a Fixes and stable tag. One could argue that enabling UHS modes is a new "feature" but I would say the original commit just missed setting the correct voltages with the intended use case. I doubt limiting to high speed was intended. Maybe also add a Suggested-by tag from myself: Fixes: 0deb2624e2d0 ("arm64: dts: qcom: sa8155p-adp: Add support for uSD card") Cc: stable@vger.kernel.org Suggested-by: Stephan Gerhold <stephan@gerhold.net> I believe you do not need to resend just to add these tags, the b4 tool should pick them up while applying. It looks like this might not work for the Cc: stable tag though... Thanks, Stephan > Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com> > --- > arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts > index b2cf2c988336c..9e9c7f81096bb 100644 > --- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts > +++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts > @@ -283,7 +283,7 @@ vreg_l12c_1p808: ldo12 { > > vreg_l13c_2p96: ldo13 { > regulator-name = "vreg_l13c_2p96"; > - regulator-min-microvolt = <2504000>; > + regulator-min-microvolt = <1800000>; > regulator-max-microvolt = <2960000>; > regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > }; > -- > 2.44.0
Hi Stephan, Stephan Gerhold <stephan@gerhold.net> writes: > On Fri, Apr 12, 2024 at 07:03:26PM +0000, Volodymyr Babchuk wrote: >> Voltage regulator L13C is used by SD card IO interface. In order to >> support UHS modes, IO interface voltage needs to be set to 1.8V. This >> patch extends minimum voltage range of L13C regulator to allow this. >> > > I think this one also deserves a Fixes and stable tag. One could argue > that enabling UHS modes is a new "feature" Yes, this was my reasoning, actually. I reasoned that the initial commit ("arm64: dts: qcom: sa8155p-adp: Add base dts file") was not obliged to set voltage ranges correctly as it didn't enabled SDHC2 support. But you are right, 0deb2624e2d0 ("arm64: dts: qcom: sa8155p-adp: Add support for uSD card") should have this change. > but I would say the original > commit just missed setting the correct voltages with the intended use > case. I doubt limiting to high speed was intended. > > Maybe also add a Suggested-by tag from myself: Yes, sorry. I should have asked about adding your Suggested-by tag before posting this change. > Fixes: 0deb2624e2d0 ("arm64: dts: qcom: sa8155p-adp: Add support for uSD card") > Cc: stable@vger.kernel.org > Suggested-by: Stephan Gerhold <stephan@gerhold.net> > > I believe you do not need to resend just to add these tags, the b4 tool > should pick them up while applying. It looks like this might not work > for the Cc: stable tag though... Well, we can send separate email to stable@vger.kernel.org after this patch will be applied... I believe it is better than posting v4.
diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts index b2cf2c988336c..9e9c7f81096bb 100644 --- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts +++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts @@ -283,7 +283,7 @@ vreg_l12c_1p808: ldo12 { vreg_l13c_2p96: ldo13 { regulator-name = "vreg_l13c_2p96"; - regulator-min-microvolt = <2504000>; + regulator-min-microvolt = <1800000>; regulator-max-microvolt = <2960000>; regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; };
Voltage regulator L13C is used by SD card IO interface. In order to support UHS modes, IO interface voltage needs to be set to 1.8V. This patch extends minimum voltage range of L13C regulator to allow this. Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com> --- arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)