| Message ID | 20240413152013.22307-5-quic_jkona@quicinc.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | PM: domains: Add control for switching back and forth to HW control | expand |
On 4/13/24 17:20, Jagadeesh Kona wrote: > The HW_CTRL_TRIGGER flag provides flexibility to switch the GDSC > mode as per the consumers requirement compared to HW_CTRL flag which > directly switches the GDSC mode as part of gdsc enable/disable. > Hence use HW_CTRL_TRIGGER flag for vcodec GDSC's to allow venus driver > to switch the vcodec GDSC to HW/SW control modes at runtime using > dev_pm_genpd_set_hwmode() API. > > Signed-off-by: Jagadeesh Kona <quic_jkona@quicinc.com> > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > --- The commit title states clk: qcom: yet the only files changed are: > drivers/clk/qcom/videocc-sc7280.c | 2 +- > drivers/clk/qcom/videocc-sm8250.c | 4 ++-- With no explanation as to why anywhere Konrad
On 4/23/2024 4:24 AM, Konrad Dybcio wrote: > > > On 4/13/24 17:20, Jagadeesh Kona wrote: >> The HW_CTRL_TRIGGER flag provides flexibility to switch the GDSC >> mode as per the consumers requirement compared to HW_CTRL flag which >> directly switches the GDSC mode as part of gdsc enable/disable. >> Hence use HW_CTRL_TRIGGER flag for vcodec GDSC's to allow venus driver >> to switch the vcodec GDSC to HW/SW control modes at runtime using >> dev_pm_genpd_set_hwmode() API. >> >> Signed-off-by: Jagadeesh Kona <quic_jkona@quicinc.com> >> Signed-off-by: Abel Vesa <abel.vesa@linaro.org> >> --- > > The commit title states clk: qcom: yet the only files changed are: > Thanks Konrad for your review! As there are 2 files with similar changes, I didn't mention file names in the commit title. >> drivers/clk/qcom/videocc-sc7280.c | 2 +- >> drivers/clk/qcom/videocc-sm8250.c | 4 ++-- > > With no explanation as to why anywhere > Sure, will update the target specific details in the commit text of next series. Thanks, Jagadeesh > Konrad
diff --git a/drivers/clk/qcom/videocc-sc7280.c b/drivers/clk/qcom/videocc-sc7280.c index cdd59c6f60df..d55613a47ff7 100644 --- a/drivers/clk/qcom/videocc-sc7280.c +++ b/drivers/clk/qcom/videocc-sc7280.c @@ -236,7 +236,7 @@ static struct gdsc mvs0_gdsc = { .name = "mvs0_gdsc", }, .pwrsts = PWRSTS_OFF_ON, - .flags = HW_CTRL | RETAIN_FF_ENABLE, + .flags = HW_CTRL_TRIGGER | RETAIN_FF_ENABLE, }; static struct gdsc mvsc_gdsc = { diff --git a/drivers/clk/qcom/videocc-sm8250.c b/drivers/clk/qcom/videocc-sm8250.c index 016b596e03b3..cac10ccd362e 100644 --- a/drivers/clk/qcom/videocc-sm8250.c +++ b/drivers/clk/qcom/videocc-sm8250.c @@ -293,7 +293,7 @@ static struct gdsc mvs0_gdsc = { .pd = { .name = "mvs0_gdsc", }, - .flags = HW_CTRL, + .flags = HW_CTRL_TRIGGER, .pwrsts = PWRSTS_OFF_ON, }; @@ -302,7 +302,7 @@ static struct gdsc mvs1_gdsc = { .pd = { .name = "mvs1_gdsc", }, - .flags = HW_CTRL, + .flags = HW_CTRL_TRIGGER, .pwrsts = PWRSTS_OFF_ON, };