| Message ID | 20240507163045.28450-1-quic_vvalluru@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v3] arm64: dts: qcom: qcs6490-rb3gen2: enable hdmi bridge | expand |
On 07/05/2024 18:30, Venkata Prahlad Valluru wrote: > Rb3Gen2 has a lt9611uxc DSI-to-HDMI bridge on i2c0, with > reset gpio from pm7250b gpio2 and irq gpio from tlmm gpio24. > Bridge supplies are Vdd connected to input supply directly > and vcc to L11c. Enable HDMI output, bridge and corresponding > DSI output. > > Signed-off-by: Venkata Prahlad Valluru <quic_vvalluru@quicinc.com> > --- > v3: - Updated commit text > - Arranged nodes in alphabetical order > - Fixed signoff > - Fixed drive strength for lt9611_irq_pin > - Removed 'label' from hdmi-connector, which is optional Please respond to each Bjorn comment and explain how did you implement it... Best regards, Krzysztof
On 5/7/2024 9:30 AM, Venkata Prahlad Valluru wrote: > Rb3Gen2 has a lt9611uxc DSI-to-HDMI bridge on i2c0, with > reset gpio from pm7250b gpio2 and irq gpio from tlmm gpio24. > Bridge supplies are Vdd connected to input supply directly > and vcc to L11c. Enable HDMI output, bridge and corresponding > DSI output. > > Signed-off-by: Venkata Prahlad Valluru <quic_vvalluru@quicinc.com> > --- > v3: - Updated commit text > - Arranged nodes in alphabetical order > - Fixed signoff > - Fixed drive strength for lt9611_irq_pin > - Removed 'label' from hdmi-connector, which is optional > > v2: Addressed dtschema errors > - Fixed lt9611-irq > - vdd-supply error to be ignored, as it is connected to > input supply directly, on rb3gen2 > --- > arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 85 ++++++++++++++++++++ > 1 file changed, 85 insertions(+) > Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
On 5/7/2024 9:35 AM, Krzysztof Kozlowski wrote: > On 07/05/2024 18:30, Venkata Prahlad Valluru wrote: >> Rb3Gen2 has a lt9611uxc DSI-to-HDMI bridge on i2c0, with >> reset gpio from pm7250b gpio2 and irq gpio from tlmm gpio24. >> Bridge supplies are Vdd connected to input supply directly >> and vcc to L11c. Enable HDMI output, bridge and corresponding >> DSI output. >> >> Signed-off-by: Venkata Prahlad Valluru <quic_vvalluru@quicinc.com> >> --- >> v3: - Updated commit text >> - Arranged nodes in alphabetical order >> - Fixed signoff >> - Fixed drive strength for lt9611_irq_pin >> - Removed 'label' from hdmi-connector, which is optional > > Please respond to each Bjorn comment and explain how did you implement it... > Yes, agreed. Even though it seems like you mostly just agreed to mine and Bjorn's suggestions and decided to implement all those in v3 , it would have been better to explicitly ack them or tell why you agreed or what went wrong that you had not done it in v2 itself to close the loop. > Best regards, > Krzysztof >
On 07/05/2024 21:20, Abhinav Kumar wrote: > > > On 5/7/2024 9:35 AM, Krzysztof Kozlowski wrote: >> On 07/05/2024 18:30, Venkata Prahlad Valluru wrote: >>> Rb3Gen2 has a lt9611uxc DSI-to-HDMI bridge on i2c0, with >>> reset gpio from pm7250b gpio2 and irq gpio from tlmm gpio24. >>> Bridge supplies are Vdd connected to input supply directly >>> and vcc to L11c. Enable HDMI output, bridge and corresponding >>> DSI output. >>> >>> Signed-off-by: Venkata Prahlad Valluru <quic_vvalluru@quicinc.com> >>> --- >>> v3: - Updated commit text >>> - Arranged nodes in alphabetical order >>> - Fixed signoff >>> - Fixed drive strength for lt9611_irq_pin >>> - Removed 'label' from hdmi-connector, which is optional >> >> Please respond to each Bjorn comment and explain how did you implement it... >> > > Yes, agreed. Even though it seems like you mostly just agreed to mine > and Bjorn's suggestions and decided to implement all those in v3 , it > would have been better to explicitly ack them or tell why you agreed or > what went wrong that you had not done it in v2 itself to close the loop. The problem is that one or more were ignored... By responding to each of them, I hope they will be finally read and understood instead of repeating the same mistake three times. Best regards, Krzysztof
On Wed, 8 May 2024 at 10:38, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 07/05/2024 21:20, Abhinav Kumar wrote: > > > > > > On 5/7/2024 9:35 AM, Krzysztof Kozlowski wrote: > >> On 07/05/2024 18:30, Venkata Prahlad Valluru wrote: > >>> Rb3Gen2 has a lt9611uxc DSI-to-HDMI bridge on i2c0, with > >>> reset gpio from pm7250b gpio2 and irq gpio from tlmm gpio24. > >>> Bridge supplies are Vdd connected to input supply directly > >>> and vcc to L11c. Enable HDMI output, bridge and corresponding > >>> DSI output. > >>> > >>> Signed-off-by: Venkata Prahlad Valluru <quic_vvalluru@quicinc.com> > >>> --- > >>> v3: - Updated commit text > >>> - Arranged nodes in alphabetical order > >>> - Fixed signoff > >>> - Fixed drive strength for lt9611_irq_pin > >>> - Removed 'label' from hdmi-connector, which is optional > >> > >> Please respond to each Bjorn comment and explain how did you implement it... > >> > > > > Yes, agreed. Even though it seems like you mostly just agreed to mine > > and Bjorn's suggestions and decided to implement all those in v3 , it > > would have been better to explicitly ack them or tell why you agreed or > > what went wrong that you had not done it in v2 itself to close the loop. > > The problem is that one or more were ignored... By responding to each of > them, I hope they will be finally read and understood instead of > repeating the same mistake three times. I found a mistake that was repeated two times. This leaves me wondering which mistake was repeated three times.
On Wed, May 08, 2024 at 09:38:50AM +0200, Krzysztof Kozlowski wrote: > On 07/05/2024 21:20, Abhinav Kumar wrote: > > > > > > On 5/7/2024 9:35 AM, Krzysztof Kozlowski wrote: > >> On 07/05/2024 18:30, Venkata Prahlad Valluru wrote: > >>> Rb3Gen2 has a lt9611uxc DSI-to-HDMI bridge on i2c0, with > >>> reset gpio from pm7250b gpio2 and irq gpio from tlmm gpio24. > >>> Bridge supplies are Vdd connected to input supply directly > >>> and vcc to L11c. Enable HDMI output, bridge and corresponding > >>> DSI output. > >>> > >>> Signed-off-by: Venkata Prahlad Valluru <quic_vvalluru@quicinc.com> > >>> --- > >>> v3: - Updated commit text > >>> - Arranged nodes in alphabetical order > >>> - Fixed signoff > >>> - Fixed drive strength for lt9611_irq_pin > >>> - Removed 'label' from hdmi-connector, which is optional > >> > >> Please respond to each Bjorn comment and explain how did you implement it... > >> > > > > Yes, agreed. Even though it seems like you mostly just agreed to mine > > and Bjorn's suggestions and decided to implement all those in v3 , it > > would have been better to explicitly ack them or tell why you agreed or > > what went wrong that you had not done it in v2 itself to close the loop. > > The problem is that one or more were ignored... By responding to each of > them, I hope they will be finally read and understood instead of > repeating the same mistake three times. Agreed. Will make sure to acknowledge the comments. > > Best regards, > Krzysztof >
On 08/05/2024 10:13, Dmitry Baryshkov wrote: > On Wed, 8 May 2024 at 10:38, Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >> On 07/05/2024 21:20, Abhinav Kumar wrote: >>> >>> >>> On 5/7/2024 9:35 AM, Krzysztof Kozlowski wrote: >>>> On 07/05/2024 18:30, Venkata Prahlad Valluru wrote: >>>>> Rb3Gen2 has a lt9611uxc DSI-to-HDMI bridge on i2c0, with >>>>> reset gpio from pm7250b gpio2 and irq gpio from tlmm gpio24. >>>>> Bridge supplies are Vdd connected to input supply directly >>>>> and vcc to L11c. Enable HDMI output, bridge and corresponding >>>>> DSI output. >>>>> >>>>> Signed-off-by: Venkata Prahlad Valluru <quic_vvalluru@quicinc.com> >>>>> --- >>>>> v3: - Updated commit text >>>>> - Arranged nodes in alphabetical order >>>>> - Fixed signoff >>>>> - Fixed drive strength for lt9611_irq_pin >>>>> - Removed 'label' from hdmi-connector, which is optional >>>> >>>> Please respond to each Bjorn comment and explain how did you implement it... >>>> >>> >>> Yes, agreed. Even though it seems like you mostly just agreed to mine >>> and Bjorn's suggestions and decided to implement all those in v3 , it >>> would have been better to explicitly ack them or tell why you agreed or >>> what went wrong that you had not done it in v2 itself to close the loop. >> >> The problem is that one or more were ignored... By responding to each of >> them, I hope they will be finally read and understood instead of >> repeating the same mistake three times. > > I found a mistake that was repeated two times. This leaves me > wondering which mistake was repeated three times. That was about future, I was expecting v4 as in-reply-to :) Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts index a085ff5b5fb2..24b0b9525ea4 100644 --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts @@ -52,6 +52,17 @@ }; }; + hdmi-connector { + compatible = "hdmi-connector"; + type = "a"; + + port { + hdmi_con: endpoint { + remote-endpoint = <<9611_out>; + }; + }; + }; + reserved-memory { xbl_mem: xbl@80700000 { reg = <0x0 0x80700000 0x0 0x100000>; @@ -530,6 +541,45 @@ <GCC_WPSS_RSCP_CLK>; }; +&i2c0 { + clock-frequency = <400000>; + status = "okay"; + + lt9611_codec: hdmi-bridge@2b { + compatible = "lontium,lt9611uxc"; + reg = <0x2b>; + + interrupts-extended = <&tlmm 24 IRQ_TYPE_EDGE_FALLING>; + reset-gpios = <&pm7250b_gpios 2 GPIO_ACTIVE_HIGH>; + + vcc-supply = <&vreg_l11c_2p8>; + + pinctrl-names = "default"; + pinctrl-0 = <<9611_irq_pin <9611_rst_pin>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + + lt9611_a: endpoint { + remote-endpoint = <&mdss_dsi0_out>; + }; + }; + + port@2 { + reg = <2>; + + lt9611_out: endpoint { + remote-endpoint = <&hdmi_con>; + }; + }; + }; + }; +}; + &i2c1 { status = "okay"; @@ -587,6 +637,21 @@ remote-endpoint = <&usb_dp_qmpphy_dp_in>; }; +&mdss_dsi { + vdda-supply = <&vreg_l6b_1p2>; + status = "okay"; +}; + +&mdss_dsi0_out { + remote-endpoint = <<9611_a>; + data-lanes = <0 1 2 3>; +}; + +&mdss_dsi_phy { + vdds-supply = <&vreg_l10c_0p88>; + status = "okay"; +}; + &mdss_edp { status = "okay"; }; @@ -711,3 +776,23 @@ function = "gpio"; bias-disable; }; + +&pm7250b_gpios { + lt9611_rst_pin: lt9611-rst-state { + pins = "gpio2"; + function = "normal"; + + output-high; + input-disable; + power-source = <0>; + }; +}; + +&tlmm { + lt9611_irq_pin: lt9611-irq-state { + pins = "gpio24"; + function = "gpio"; + drive-strength = <2>; + bias-disable; + }; +};
Rb3Gen2 has a lt9611uxc DSI-to-HDMI bridge on i2c0, with reset gpio from pm7250b gpio2 and irq gpio from tlmm gpio24. Bridge supplies are Vdd connected to input supply directly and vcc to L11c. Enable HDMI output, bridge and corresponding DSI output. Signed-off-by: Venkata Prahlad Valluru <quic_vvalluru@quicinc.com> --- v3: - Updated commit text - Arranged nodes in alphabetical order - Fixed signoff - Fixed drive strength for lt9611_irq_pin - Removed 'label' from hdmi-connector, which is optional v2: Addressed dtschema errors - Fixed lt9611-irq - vdd-supply error to be ignored, as it is connected to input supply directly, on rb3gen2 --- arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 85 ++++++++++++++++++++ 1 file changed, 85 insertions(+)