| Message ID | 20240516152537.262354-1-linux@treblig.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2] dmaengine: qcom: gpi: remove unused struct 'reg_info' | expand |
On 16/05/2024 17:25, linux@treblig.org wrote: > From: "Dr. David Alan Gilbert" <linux@treblig.org> > > Remove unused struct 'reg_info' > > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org> > --- > drivers/dma/qcom/gpi.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c > index 1c93864e0e4d..639ab304db9b 100644 > --- a/drivers/dma/qcom/gpi.c > +++ b/drivers/dma/qcom/gpi.c > @@ -476,12 +476,6 @@ struct gpi_dev { > struct gpii *gpiis; > }; > > -struct reg_info { > - char *name; > - u32 offset; > - u32 val; > -}; > - > struct gchan { > struct virt_dma_chan vc; > u32 chid; More detail in the commit log please - is the structure unused ? What is the provenance of it being added and becoming dead code. More detail required here. --- bod
* Bryan O'Donoghue (bryan.odonoghue@linaro.org) wrote: > On 16/05/2024 17:25, linux@treblig.org wrote: > > From: "Dr. David Alan Gilbert" <linux@treblig.org> > > > > Remove unused struct 'reg_info' > > > > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org> > > --- > > drivers/dma/qcom/gpi.c | 6 ------ > > 1 file changed, 6 deletions(-) > > > > diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c > > index 1c93864e0e4d..639ab304db9b 100644 > > --- a/drivers/dma/qcom/gpi.c > > +++ b/drivers/dma/qcom/gpi.c > > @@ -476,12 +476,6 @@ struct gpi_dev { > > struct gpii *gpiis; > > }; > > -struct reg_info { > > - char *name; > > - u32 offset; > > - u32 val; > > -}; > > - > > struct gchan { > > struct virt_dma_chan vc; > > u32 chid; Hi Bryan, > More detail in the commit log please - is the structure unused ? What is the > provenance of it being added and becoming dead code. > > More detail required here. If you look at the V1 I had ''gpi_desc' seems like it was never used. Remove it.' but Frank suggested copying the subject line; so I'm not sure whether you want more or less! I could change this to: 'gpi_desc' was never used since it's initial commit 5d0c3533a19f ("dmaengine: qcom: Add GPI dma driver") Would you be OK with that? Dave > > --- > bod >
* Dr. David Alan Gilbert (linux@treblig.org) wrote: > * Bryan O'Donoghue (bryan.odonoghue@linaro.org) wrote: > > On 16/05/2024 17:25, linux@treblig.org wrote: > > > From: "Dr. David Alan Gilbert" <linux@treblig.org> > > > > > > Remove unused struct 'reg_info' > > > > > > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org> > > > --- > > > drivers/dma/qcom/gpi.c | 6 ------ > > > 1 file changed, 6 deletions(-) > > > > > > diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c > > > index 1c93864e0e4d..639ab304db9b 100644 > > > --- a/drivers/dma/qcom/gpi.c > > > +++ b/drivers/dma/qcom/gpi.c > > > @@ -476,12 +476,6 @@ struct gpi_dev { > > > struct gpii *gpiis; > > > }; > > > -struct reg_info { > > > - char *name; > > > - u32 offset; > > > - u32 val; > > > -}; > > > - > > > struct gchan { > > > struct virt_dma_chan vc; > > > u32 chid; > > Hi Bryan, > > > More detail in the commit log please - is the structure unused ? What is the > > provenance of it being added and becoming dead code. > > > > More detail required here. > > If you look at the V1 I had > ''gpi_desc' seems like it was never used. > Remove it.' > > but Frank suggested copying the subject line; so I'm not sure > whether you want more or less! > > I could change this to: > > 'gpi_desc' was never used since it's initial > commit 5d0c3533a19f ("dmaengine: qcom: Add GPI dma driver") Oops, of course I mean 'reg_info' which is what I fixed in v2. > Would you be OK with that? Dave > Dave > > > > > > --- > > bod > > > -- > -----Open up your eyes, open up your mind, open up your code ------- > / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ > \ dave @ treblig.org | | In Hex / > \ _________________________|_____ http://www.treblig.org |_______/ >
On 17/05/2024 12:19, Dr. David Alan Gilbert wrote: >> If you look at the V1 I had >> ''gpi_desc' seems like it was never used. >> Remove it.' >> >> but Frank suggested copying the subject line; so I'm not sure >> whether you want more or less! >> >> I could change this to: >> >> 'gpi_desc' was never used since it's initial >> commit 5d0c3533a19f ("dmaengine: qcom: Add GPI dma driver") > Oops, of course I mean 'reg_info' which is what I fixed in v2. > >> Would you be OK with that? > Dave > >> Dave Hi Dave, I saw your v1 interaction after commenting but, I still think commits that say "this removes a data structure" should elaborate more. "This structure is no longer used since commit: 12charsubshahere" or "This structure was never used and should be considered dead code" I generally hope the intention of my commits is clear from the code with the commit log adding whatever context or elaboration on top. So that's what I'm suggesting here. A bit of commit log sugar on top which elaborates on and justifies the change. --- bod
* Bryan O'Donoghue (bryan.odonoghue@linaro.org) wrote: > On 17/05/2024 12:19, Dr. David Alan Gilbert wrote: > > > If you look at the V1 I had > > > ''gpi_desc' seems like it was never used. > > > Remove it.' > > > > > > but Frank suggested copying the subject line; so I'm not sure > > > whether you want more or less! > > > > > > I could change this to: > > > > > > 'gpi_desc' was never used since it's initial > > > commit 5d0c3533a19f ("dmaengine: qcom: Add GPI dma driver") > > Oops, of course I mean 'reg_info' which is what I fixed in v2. > > > > > Would you be OK with that? > > Dave > > > > > Dave > > Hi Dave, > > I saw your v1 interaction after commenting but, I still think commits that > say "this removes a data structure" should elaborate more. > > "This structure is no longer used since commit: 12charsubshahere" or "This > structure was never used and should be considered dead code" > > I generally hope the intention of my commits is clear from the code with the > commit log adding whatever context or elaboration on top. > > So that's what I'm suggesting here. A bit of commit log sugar on top which > elaborates on and justifies the change. OK, so how about the version I suggested above: 'reg_info' was never used since it's initial commit 5d0c3533a19f ("dmaengine: qcom: Add GPI dma driver") Remove it. Is that OK with you? Dave > > --- > bod >
On 18/05/2024 00:04, Dr. David Alan Gilbert wrote: > * Bryan O'Donoghue (bryan.odonoghue@linaro.org) wrote: >> On 17/05/2024 12:19, Dr. David Alan Gilbert wrote: >>>> If you look at the V1 I had >>>> ''gpi_desc' seems like it was never used. >>>> Remove it.' >>>> >>>> but Frank suggested copying the subject line; so I'm not sure >>>> whether you want more or less! >>>> >>>> I could change this to: >>>> >>>> 'gpi_desc' was never used since it's initial >>>> commit 5d0c3533a19f ("dmaengine: qcom: Add GPI dma driver") >>> Oops, of course I mean 'reg_info' which is what I fixed in v2. >>> >>>> Would you be OK with that? >>> Dave >>> >>>> Dave >> >> Hi Dave, >> >> I saw your v1 interaction after commenting but, I still think commits that >> say "this removes a data structure" should elaborate more. >> >> "This structure is no longer used since commit: 12charsubshahere" or "This >> structure was never used and should be considered dead code" >> >> I generally hope the intention of my commits is clear from the code with the >> commit log adding whatever context or elaboration on top. >> >> So that's what I'm suggesting here. A bit of commit log sugar on top which >> elaborates on and justifies the change. > > OK, so how about the version I suggested above: > > 'reg_info' was never used since it's initial > commit 5d0c3533a19f ("dmaengine: qcom: Add GPI dma driver") > Remove it. > > Is that OK with you? > > Dave > >> >> --- >> bod >> LGTM Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
* Bryan O'Donoghue (bryan.odonoghue@linaro.org) wrote: > On 18/05/2024 00:04, Dr. David Alan Gilbert wrote: > > * Bryan O'Donoghue (bryan.odonoghue@linaro.org) wrote: > > > On 17/05/2024 12:19, Dr. David Alan Gilbert wrote: > > > > > If you look at the V1 I had > > > > > ''gpi_desc' seems like it was never used. > > > > > Remove it.' > > > > > > > > > > but Frank suggested copying the subject line; so I'm not sure > > > > > whether you want more or less! > > > > > > > > > > I could change this to: > > > > > > > > > > 'gpi_desc' was never used since it's initial > > > > > commit 5d0c3533a19f ("dmaengine: qcom: Add GPI dma driver") > > > > Oops, of course I mean 'reg_info' which is what I fixed in v2. > > > > > > > > > Would you be OK with that? > > > > Dave > > > > > > > > > Dave > > > > > > Hi Dave, > > > > > > I saw your v1 interaction after commenting but, I still think commits that > > > say "this removes a data structure" should elaborate more. > > > > > > "This structure is no longer used since commit: 12charsubshahere" or "This > > > structure was never used and should be considered dead code" > > > > > > I generally hope the intention of my commits is clear from the code with the > > > commit log adding whatever context or elaboration on top. > > > > > > So that's what I'm suggesting here. A bit of commit log sugar on top which > > > elaborates on and justifies the change. > > > > OK, so how about the version I suggested above: > > > > 'reg_info' was never used since it's initial > > commit 5d0c3533a19f ("dmaengine: qcom: Add GPI dma driver") > > Remove it. > > > > Is that OK with you? > > > > Dave > > > > > > > > --- > > > bod > > > > > LGTM > > Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> Thanks, v3 sent and copied to you with that RB added. Dave
diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c index 1c93864e0e4d..639ab304db9b 100644 --- a/drivers/dma/qcom/gpi.c +++ b/drivers/dma/qcom/gpi.c @@ -476,12 +476,6 @@ struct gpi_dev { struct gpii *gpiis; }; -struct reg_info { - char *name; - u32 offset; - u32 val; -}; - struct gchan { struct virt_dma_chan vc; u32 chid;