diff mbox series

arm64: dts: qcom: msm8996: add reset for display subsystem

Message ID 20240525-mdss-reset-v1-1-c0489e8be0d0@gmail.com (mailing list archive)
State Accepted
Headers show
Series arm64: dts: qcom: msm8996: add reset for display subsystem | expand

Commit Message

Barnabás Czémán May 25, 2024, 2:08 p.m. UTC
Add reset for display subsystem, make sure it gets
properly reset.

Signed-off-by: Barnabás Czémán <trabarni@gmail.com>
---
 arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 ++
 1 file changed, 2 insertions(+)


---
base-commit: 3689b0ef08b70e4e03b82ebd37730a03a672853a
change-id: 20240525-mdss-reset-8b83eaa24b8c

Best regards,

Comments

Markus Elfring May 25, 2024, 6:20 p.m. UTC | #1
> Add reset for display subsystem, make sure it gets
> properly reset.

* I suggest to use occasionally more than 50 characters in lines of
  such change descriptions.

* Please reconsider word wrapping accordingly.

* Can such information be relevant for the tag “Fixes”?

Regards,
Markus
Krzysztof Kozlowski May 25, 2024, 6:29 p.m. UTC | #2
On 25/05/2024 20:20, Markus Elfring wrote:
>> Add reset for display subsystem, make sure it gets
>> properly reset.
> 
> * I suggest to use occasionally more than 50 characters in lines of
>   such change descriptions.
> 
> * Please reconsider word wrapping accordingly.
> 
> * Can such information be relevant for the tag “Fixes”?

<form letter>
Feel free to ignore all comments from Markus, regardless whether the
suggestion is reasonable or not. This person is banned from LKML and
most maintainers ignore Markus' feedback, because it is just a waste of
time.
</form letter>

Best regards,
Krzysztof
Dmitry Baryshkov May 25, 2024, 8:03 p.m. UTC | #3
On Sat, 25 May 2024 at 17:09, Barnabás Czémán <trabarni@gmail.com> wrote:
>
> Add reset for display subsystem, make sure it gets
> properly reset.
>
> Signed-off-by: Barnabás Czémán <trabarni@gmail.com>
> ---
>  arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

[No need to apply any fixes tags, it is not a bug that was present
before and is being fixed, it is an additional functionality]
Bjorn Andersson May 27, 2024, 3 a.m. UTC | #4
On Sat, 25 May 2024 16:08:57 +0200, Barnabás Czémán wrote:
> Add reset for display subsystem, make sure it gets
> properly reset.
> 
> 

Applied, thanks!

[1/1] arm64: dts: qcom: msm8996: add reset for display subsystem
      commit: b3f8cdef8a5c0bc89ceb1095856f64ba7445c6b9

Best regards,
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
index 8d2cb6f41095..5348feac026e 100644
--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
@@ -982,6 +982,8 @@  mdss: display-subsystem@900000 {
 				 <&mmcc MDSS_MDP_CLK>;
 			clock-names = "iface", "core";
 
+			resets = <&mmcc MDSS_BCR>;
+
 			#address-cells = <1>;
 			#size-cells = <1>;
 			ranges;