| Message ID | 20240605160032.150587-4-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 05d84f973d84d23e0a249ae5b3f6d7572fdc5e1e |
| Headers | show |
| Series | [RFT,1/4] arm64: dts: qcom: sm6350-pdx213: correct touchscreen interrupt flags | expand |
On 5.06.2024 6:00 PM, Krzysztof Kozlowski wrote: > Interrupt flags 0x2008 looks like some downstream copy-paste, because > generic GPIOLIB code, used by Qualcomm pin controller drivers, ignores > flags outside of IRQ_TYPE_SENSE_MASK. Probably the intention was to > pass just 0x8, so IRQ_TYPE_LEVEL_LOW. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- I only tested on one 8450 device, but they're all: - the same tlmm - the same geni - the same touchscreen so I suppose it's alright Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Tested-by: Konrad Dybcio <konrad.dybcio@linaro.org> # SM8450 PDX223 Konrad
diff --git a/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara.dtsi b/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara.dtsi index 8b29fcf483a3..17dbb67868ae 100644 --- a/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara.dtsi @@ -488,7 +488,7 @@ touchscreen@48 { compatible = "samsung,s6sy761"; reg = <0x48>; interrupt-parent = <&tlmm>; - interrupts = <21 0x2008>; + interrupts = <21 IRQ_TYPE_LEVEL_LOW>; vdd-supply = <&pm8350c_l2>; avdd-supply = <&pm8350c_l3>;
Interrupt flags 0x2008 looks like some downstream copy-paste, because generic GPIOLIB code, used by Qualcomm pin controller drivers, ignores flags outside of IRQ_TYPE_SENSE_MASK. Probably the intention was to pass just 0x8, so IRQ_TYPE_LEVEL_LOW. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)