| Message ID | 20240618-starqltechn_integration_upstream-v3-4-e3f6662017ac@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | This is continued work on Samsung S9(SM-9600) starqltechn | expand |
On Tue, 18 Jun 2024 16:59:38 +0300, Dzmitry Sankouski wrote: > maxim,max77705 is MAX77705 pmic binding part > > Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com> > --- > .../devicetree/bindings/mfd/maxim,max77705.yaml | 112 +++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 113 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/maxim,max77705.example.dtb: pmic@66: charger: False schema does not allow {'compatible': ['maxim,max77705-charger'], 'monitored-battery': [[4294967295]], 'phandle': [[2]]} from schema $id: http://devicetree.org/schemas/mfd/maxim,max77705.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/maxim,max77705.example.dtb: pmic@66: fuelgauge: False schema does not allow {'compatible': ['maxim,max77705-fg'], 'monitored-battery': [[4294967295]], 'power-supplies': [[2]], 'rsense': [[5]]} from schema $id: http://devicetree.org/schemas/mfd/maxim,max77705.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/maxim,max77705.example.dtb: pmic@66: haptic: False schema does not allow {'compatible': ['maxim,max77705-haptic'], 'haptic-supply': [[4294967295]], 'pwms': [[4294967295, 0, 50000]]} from schema $id: http://devicetree.org/schemas/mfd/maxim,max77705.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/maxim,max77705.example.dtb: pmic@66: leds: False schema does not allow {'compatible': ['maxim,max77705-led'], '#address-cells': [[1]], '#size-cells': [[0]], 'led@1': {'reg': [[1]], 'label': ['red:usr1']}, 'led@2': {'reg': [[2]], 'label': ['green:usr2']}, 'led@3': {'reg': [[3]], 'label': ['blue:usr3']}} from schema $id: http://devicetree.org/schemas/mfd/maxim,max77705.yaml# Documentation/devicetree/bindings/mfd/maxim,max77705.example.dtb: /example-0/i2c14/pmic@66/leds: failed to match any schema with compatible: ['maxim,max77705-led'] Documentation/devicetree/bindings/mfd/maxim,max77705.example.dtb: /example-0/i2c14/pmic@66/charger: failed to match any schema with compatible: ['maxim,max77705-charger'] Documentation/devicetree/bindings/mfd/maxim,max77705.example.dtb: /example-0/i2c14/pmic@66/fuelgauge: failed to match any schema with compatible: ['maxim,max77705-fg'] Documentation/devicetree/bindings/mfd/maxim,max77705.example.dtb: /example-0/i2c14/pmic@66/haptic: failed to match any schema with compatible: ['maxim,max77705-haptic'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240618-starqltechn_integration_upstream-v3-4-e3f6662017ac@gmail.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 18/06/2024 15:59, Dzmitry Sankouski wrote: > maxim,max77705 is MAX77705 pmic binding part > > Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com> > --- > .../devicetree/bindings/mfd/maxim,max77705.yaml | 112 +++++++++++++++++++++ Your patch order is totally messed. Not tested by automation. Only limited review follows. > MAINTAINERS | 1 + > 2 files changed, 113 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/maxim,max77705.yaml b/Documentation/devicetree/bindings/mfd/maxim,max77705.yaml > new file mode 100644 > index 000000000000..b54408e3d792 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/maxim,max77705.yaml > @@ -0,0 +1,112 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/maxim,max77705.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Maxim MAX77705 Companion Power Management IC and USB Type-C interface IC > + > +maintainers: > + - Dzmitry Sankouski <dsankouski@gmail.com> > + > +description: | > + This is a part of device tree bindings for Maxim MAX77705 multi functional device. > + > + The Maxim MAX77705 is a Companion Power Management and Type-C interface IC which > + includes charger, fuelgauge, LED, haptic motor driver and Type-C management IC. > + > +properties: > + compatible: > + const: maxim,max77705 > + > + reg: > + description: > + I2C device address. Drop description, obvious. > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + interrupt-names: > + description: > + MAX77705 shared irq. > + items: > + - const: max77705_irq Drop entire property, not really useful. > + > + charger: > + $ref: /schemas/power/supply/maxim,max77705-charger.yaml > + > + fuelgauge: > + $ref: /schemas/power/supply/maxim,max77705-fg.yaml > + > + haptic: > + $ref: /schemas/input/maxim,max77705.yaml > + > + leds: > + $ref: /schemas/leds/maxim,max77705.yaml > + > + > +required: > + - compatible > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + #include <dt-bindings/leds/common.h> > + > + i2c14 { i2c > + #address-cells = <1>; > + #size-cells = <0>; > + > + pmic@66 { > + compatible = "maxim,max77705"; > + reg = <0x66>; Totally messed indentation. Fix your code. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/mfd/maxim,max77705.yaml b/Documentation/devicetree/bindings/mfd/maxim,max77705.yaml new file mode 100644 index 000000000000..b54408e3d792 --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/maxim,max77705.yaml @@ -0,0 +1,112 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/maxim,max77705.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Maxim MAX77705 Companion Power Management IC and USB Type-C interface IC + +maintainers: + - Dzmitry Sankouski <dsankouski@gmail.com> + +description: | + This is a part of device tree bindings for Maxim MAX77705 multi functional device. + + The Maxim MAX77705 is a Companion Power Management and Type-C interface IC which + includes charger, fuelgauge, LED, haptic motor driver and Type-C management IC. + +properties: + compatible: + const: maxim,max77705 + + reg: + description: + I2C device address. + maxItems: 1 + + interrupts: + maxItems: 1 + + interrupt-names: + description: + MAX77705 shared irq. + items: + - const: max77705_irq + + charger: + $ref: /schemas/power/supply/maxim,max77705-charger.yaml + + fuelgauge: + $ref: /schemas/power/supply/maxim,max77705-fg.yaml + + haptic: + $ref: /schemas/input/maxim,max77705.yaml + + leds: + $ref: /schemas/leds/maxim,max77705.yaml + + +required: + - compatible + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + #include <dt-bindings/leds/common.h> + + i2c14 { + #address-cells = <1>; + #size-cells = <0>; + + pmic@66 { + compatible = "maxim,max77705"; + reg = <0x66>; + interrupt-parent = <&pm8998_gpios>; + interrupts = <11 IRQ_TYPE_LEVEL_LOW>; + interrupt-names = "max77705_irq"; + pinctrl-0 = <&chg_int_default>; + pinctrl-names = "default"; + + leds { + compatible = "maxim,max77705-led"; + #address-cells = <1>; + #size-cells = <0>; + + led@1 { + reg = <1>; + label = "red:usr1"; + }; + + led@2 { + reg = <2>; + label = "green:usr2"; + }; + + led@3 { + reg = <3>; + label = "blue:usr3"; + }; + }; + + max77705_charger: charger { + compatible = "maxim,max77705-charger"; + monitored-battery = <&battery>; + }; + + fuelgauge { + compatible = "maxim,max77705-fg"; + monitored-battery = <&battery>; + power-supplies = <&max77705_charger>; + rsense = <5>; + }; + + + haptic { + compatible = "maxim,max77705-haptic"; + haptic-supply = <&vib_regulator>; + pwms = <&vib_pwm 0 50000>; + }; + }; + }; diff --git a/MAINTAINERS b/MAINTAINERS index fddbd50f7685..f008429033c9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -13682,6 +13682,7 @@ B: mailto:linux-samsung-soc@vger.kernel.org F: Documentation/devicetree/bindings/*/maxim,max14577.yaml F: Documentation/devicetree/bindings/*/maxim,max77686.yaml F: Documentation/devicetree/bindings/*/maxim,max77693.yaml +F: Documentation/devicetree/bindings/*/maxim,max77705*.yaml F: Documentation/devicetree/bindings/*/maxim,max77843.yaml F: Documentation/devicetree/bindings/clock/maxim,max77686.txt F: drivers/*/*max77843.c
maxim,max77705 is MAX77705 pmic binding part Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com> --- .../devicetree/bindings/mfd/maxim,max77705.yaml | 112 +++++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 113 insertions(+)