diff mbox series

[2/3] arm64: dts: qcom: sm8350: move usb-role-switch to sm8350.dtsi

Message ID 20240624-b4-rb2-fixes-v1-2-8d763ee4e42e@linaro.org (mailing list archive)
State New
Headers show
Series arm64: dts: qcom: make dev boards prefer usb host mode | expand

Commit Message

Caleb Connolly June 24, 2024, 12:23 p.m. UTC
Since all boards with this soc are capable of role switching, move the
usb-role-switch property to the soc dtsi and stop explicitly setting
dr_mode to OTG since it's the default.

Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
---
 arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 5 -----
 arch/arm64/boot/dts/qcom/sm8350.dtsi    | 1 +
 2 files changed, 1 insertion(+), 5 deletions(-)

Comments

Dmitry Baryshkov June 24, 2024, 1:11 p.m. UTC | #1
On Mon, Jun 24, 2024 at 02:23:43PM GMT, Caleb Connolly wrote:
> Since all boards with this soc are capable of role switching, move the
> usb-role-switch property to the soc dtsi and stop explicitly setting
> dr_mode to OTG since it's the default.
> 
> Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 5 -----
>  arch/arm64/boot/dts/qcom/sm8350.dtsi    | 1 +
>  2 files changed, 1 insertion(+), 5 deletions(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
index 895adce59e75..e031ad4c19f4 100644
--- a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
+++ b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
@@ -847,13 +847,8 @@  &ufs_mem_phy {
 &usb_1 {
 	status = "okay";
 };
 
-&usb_1_dwc3 {
-	dr_mode = "otg";
-	usb-role-switch;
-};
-
 &usb_1_dwc3_hs {
 	remote-endpoint = <&pmic_glink_hs_in>;
 };
 
diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi
index 38ee0850c335..f88c4d66164b 100644
--- a/arch/arm64/boot/dts/qcom/sm8350.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi
@@ -2404,8 +2404,9 @@  usb_1_dwc3: usb@a600000 {
 				snps,dis_u2_susphy_quirk;
 				snps,dis_enblslpm_quirk;
 				phys = <&usb_1_hsphy>, <&usb_1_qmpphy QMP_USB43DP_USB3_PHY>;
 				phy-names = "usb2-phy", "usb3-phy";
+				usb-role-switch;
 
 				ports {
 					#address-cells = <1>;
 					#size-cells = <0>;