| Message ID | 20240716160631.386713-1-robdclark@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | drm/msm/adreno: Fix error return if missing firmware-name | expand |
On Tue, Jul 16, 2024 at 09:06:30AM GMT, Rob Clark wrote: > From: Rob Clark <robdclark@chromium.org> > > -ENODEV is used to signify that there is no zap shader for the platform, > and the CPU can directly take the GPU out of secure mode. We want to > use this return code when there is no zap-shader node. But not when > there is, but without a firmware-name property. This case we want to > treat as-if the needed fw is not found. > > Signed-off-by: Rob Clark <robdclark@chromium.org> > --- > drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
On Tue, Jul 16, 2024 at 09:06:30AM -0700, Rob Clark wrote: > From: Rob Clark <robdclark@chromium.org> > > -ENODEV is used to signify that there is no zap shader for the platform, > and the CPU can directly take the GPU out of secure mode. We want to > use this return code when there is no zap-shader node. But not when > there is, but without a firmware-name property. This case we want to > treat as-if the needed fw is not found. > > Signed-off-by: Rob Clark <robdclark@chromium.org> > --- Reviewed-by: Akhil P Oommen <quic_akhilpo@quicinc.com> -Akhil > drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c > index b46e7e93b3ed..0d84be3be0b7 100644 > --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c > +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c > @@ -99,7 +99,7 @@ static int zap_shader_load_mdt(struct msm_gpu *gpu, const char *fwname, > * was a bad idea, and is only provided for backwards > * compatibility for older targets. > */ > - return -ENODEV; > + return -ENOENT; > } > > if (IS_ERR(fw)) { > -- > 2.45.2 >
diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c index b46e7e93b3ed..0d84be3be0b7 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c @@ -99,7 +99,7 @@ static int zap_shader_load_mdt(struct msm_gpu *gpu, const char *fwname, * was a bad idea, and is only provided for backwards * compatibility for older targets. */ - return -ENODEV; + return -ENOENT; } if (IS_ERR(fw)) {