| Message ID | 20240717094848.3536239-2-quic_varada@quicinc.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 60a76f7826b88ebf7697a56fdcd9596b23c2b616 |
| Headers | show |
| Series | [v2,1/2] dt-bindings: usb: qcom,dwc3: Update ipq5332 interrupt info | expand |
On 17.07.2024 11:48 AM, Varadarajan Narayanan wrote: > Trigger type is incorrectly specified as IRQ_TYPE_EDGE_BOTH > instead of IRQ_TYPE_LEVEL_HIGH. This trigger type is not > supported for SPIs and results in probe failure with -EINVAL. > > Fixes: 927173bf8a0e ("arm64: dts: qcom: Add missing interrupts for qcs404/ipq5332") > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > --- > arch/arm64/boot/dts/qcom/ipq5332.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi > index f58fd70be826..56304f996dbf 100644 > --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi > @@ -322,8 +322,8 @@ usb: usb@8af8800 { > reg = <0x08af8800 0x400>; > > interrupts = <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>, > - <GIC_SPI 53 IRQ_TYPE_EDGE_BOTH>, > - <GIC_SPI 52 IRQ_TYPE_EDGE_BOTH>; > + <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>; Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Probably worth asking, is there a MPM/PDC on this platform? Konrad
On Wed, Jul 17, 2024 at 11:55:44AM GMT, Konrad Dybcio wrote: > On 17.07.2024 11:48 AM, Varadarajan Narayanan wrote: > > Trigger type is incorrectly specified as IRQ_TYPE_EDGE_BOTH > > instead of IRQ_TYPE_LEVEL_HIGH. This trigger type is not > > supported for SPIs and results in probe failure with -EINVAL. > > > > Fixes: 927173bf8a0e ("arm64: dts: qcom: Add missing interrupts for qcs404/ipq5332") > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > > --- > > arch/arm64/boot/dts/qcom/ipq5332.dtsi | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi > > index f58fd70be826..56304f996dbf 100644 > > --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi > > +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi > > @@ -322,8 +322,8 @@ usb: usb@8af8800 { > > reg = <0x08af8800 0x400>; > > > > interrupts = <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>, > > - <GIC_SPI 53 IRQ_TYPE_EDGE_BOTH>, > > - <GIC_SPI 52 IRQ_TYPE_EDGE_BOTH>; > > + <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>; > > Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> > > Probably worth asking, is there a MPM/PDC on this platform? Judging by the vendor DT, there is none: https://git.codelinaro.org/clo/qsdk/oss/kernel/linux-ipq-files/-/blob/NHSS.QSDK.12.4.5.r5/arch/arm64/boot/dts/qcom/ipq5332.dtsi?ref_type=heads
diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi index f58fd70be826..56304f996dbf 100644 --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi @@ -322,8 +322,8 @@ usb: usb@8af8800 { reg = <0x08af8800 0x400>; interrupts = <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 53 IRQ_TYPE_EDGE_BOTH>, - <GIC_SPI 52 IRQ_TYPE_EDGE_BOTH>; + <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>; interrupt-names = "pwr_event", "dp_hs_phy_irq", "dm_hs_phy_irq";
Trigger type is incorrectly specified as IRQ_TYPE_EDGE_BOTH instead of IRQ_TYPE_LEVEL_HIGH. This trigger type is not supported for SPIs and results in probe failure with -EINVAL. Fixes: 927173bf8a0e ("arm64: dts: qcom: Add missing interrupts for qcs404/ipq5332") Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> --- arch/arm64/boot/dts/qcom/ipq5332.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)