diff mbox series

[1/3] dt-bindings: arm: qcom: Add Lenovo ThinkPad T14s Gen 6

Message ID 20240719-topic-t14s_upstream-v1-1-d7d97fdebb28@linaro.org (mailing list archive)
State Changes Requested
Headers show
Series ThinkPad T14s Gen 6 support | expand

Commit Message

Konrad Dybcio July 19, 2024, 8:16 p.m. UTC
Document the X1E78100-based ThinkPad.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Krzysztof Kozlowski July 21, 2024, 10:22 a.m. UTC | #1
On 19/07/2024 22:16, Konrad Dybcio wrote:
> Document the X1E78100-based ThinkPad.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
>  Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Rob Herring (Arm) July 22, 2024, 9:24 p.m. UTC | #2
On Fri, Jul 19, 2024 at 10:16:36PM +0200, Konrad Dybcio wrote:
> Document the X1E78100-based ThinkPad.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
>  Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index f08e13b61172..8af56b602de3 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -1038,6 +1038,12 @@ properties:
>                - qcom,sm8650-qrd
>            - const: qcom,sm8650
>  
> +      - items:
> +          - enum:
> +              - lenovo,thinkpad-t14s
> +          - const: qcom,x1e78100
> +          - const: qcom,x1e80100

Why 2 chip compatibles? Please explain in the commit msg.

> +
>        - items:
>            - enum:
>                - asus,vivobook-s15
> 
> -- 
> 2.45.2
>
Konrad Dybcio July 22, 2024, 10:40 p.m. UTC | #3
On 22.07.2024 11:24 PM, Rob Herring wrote:
> On Fri, Jul 19, 2024 at 10:16:36PM +0200, Konrad Dybcio wrote:
>> Document the X1E78100-based ThinkPad.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
>>  Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>> index f08e13b61172..8af56b602de3 100644
>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>> @@ -1038,6 +1038,12 @@ properties:
>>                - qcom,sm8650-qrd
>>            - const: qcom,sm8650
>>  
>> +      - items:
>> +          - enum:
>> +              - lenovo,thinkpad-t14s
>> +          - const: qcom,x1e78100
>> +          - const: qcom,x1e80100
> 
> Why 2 chip compatibles? Please explain in the commit msg.

Just like other entries in this yaml, the one in the middle is a
fuse variant of the latter one. I'll mention this.

Konrad
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index f08e13b61172..8af56b602de3 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -1038,6 +1038,12 @@  properties:
               - qcom,sm8650-qrd
           - const: qcom,sm8650
 
+      - items:
+          - enum:
+              - lenovo,thinkpad-t14s
+          - const: qcom,x1e78100
+          - const: qcom,x1e80100
+
       - items:
           - enum:
               - asus,vivobook-s15