| Message ID | 20240722-pmic-bindings-v1-3-555942b3c4e1@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm(64): dts: qcom: fix dtbs_check warnings for qcom,spmi-pmic.yaml | expand |
On 22.07.2024 1:47 PM, Rayyan Ansari wrote: > Wrap existing pwrkey node inside a pon node, to conform to dt schema. > > Signed-off-by: Rayyan Ansari <rayyan.ansari@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> might also wanna polish it up so that KEY_POWER is assigned Konrad
On Mon, Jul 22, 2024 at 12:47:57PM GMT, Rayyan Ansari wrote: > Wrap existing pwrkey node inside a pon node, to conform to dt schema. > > Signed-off-by: Rayyan Ansari <rayyan.ansari@linaro.org> > --- > arch/arm/boot/dts/qcom/pma8084.dtsi | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/boot/dts/qcom/pma8084.dtsi b/arch/arm/boot/dts/qcom/pma8084.dtsi > index 2985f4805b93..dbf7afcbfd8b 100644 > --- a/arch/arm/boot/dts/qcom/pma8084.dtsi > +++ b/arch/arm/boot/dts/qcom/pma8084.dtsi > @@ -19,12 +19,16 @@ rtc@6000 { > interrupts = <0x0 0x61 0x1 IRQ_TYPE_EDGE_RISING>; > }; > > - pwrkey@800 { > - compatible = "qcom,pm8941-pwrkey"; > + pon@800 { > + compatible = "qcom,pm8941-pon"; > reg = <0x800>; > - interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>; > - debounce = <15625>; > - bias-pull-up; > + > + pwrkey { > + compatible = "qcom,pm8941-pwrkey"; > + interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>; > + debounce = <15625>; > + bias-pull-up; > + }; It might be worth adding the resin node too, see pm8941.dtsi > }; > > pma8084_gpios: gpio@c000 { > > -- > 2.45.2 >
On 23.07.2024 1:35 PM, Dmitry Baryshkov wrote: > On Mon, Jul 22, 2024 at 12:47:57PM GMT, Rayyan Ansari wrote: >> Wrap existing pwrkey node inside a pon node, to conform to dt schema. >> >> Signed-off-by: Rayyan Ansari <rayyan.ansari@linaro.org> >> --- >> arch/arm/boot/dts/qcom/pma8084.dtsi | 14 +++++++++----- >> 1 file changed, 9 insertions(+), 5 deletions(-) >> >> diff --git a/arch/arm/boot/dts/qcom/pma8084.dtsi b/arch/arm/boot/dts/qcom/pma8084.dtsi >> index 2985f4805b93..dbf7afcbfd8b 100644 >> --- a/arch/arm/boot/dts/qcom/pma8084.dtsi >> +++ b/arch/arm/boot/dts/qcom/pma8084.dtsi >> @@ -19,12 +19,16 @@ rtc@6000 { >> interrupts = <0x0 0x61 0x1 IRQ_TYPE_EDGE_RISING>; >> }; >> >> - pwrkey@800 { >> - compatible = "qcom,pm8941-pwrkey"; >> + pon@800 { >> + compatible = "qcom,pm8941-pon"; >> reg = <0x800>; >> - interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>; >> - debounce = <15625>; >> - bias-pull-up; >> + >> + pwrkey { >> + compatible = "qcom,pm8941-pwrkey"; >> + interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>; >> + debounce = <15625>; >> + bias-pull-up; >> + }; > > It might be worth adding the resin node too, see pm8941.dtsi This is a cleanup series, adding features is another thing and it would be nice if somebody could test it Konrad
On Tue, 23 Jul 2024 at 14:39, Konrad Dybcio <konrad.dybcio@linaro.org> wrote: > > On 23.07.2024 1:35 PM, Dmitry Baryshkov wrote: > > On Mon, Jul 22, 2024 at 12:47:57PM GMT, Rayyan Ansari wrote: > >> Wrap existing pwrkey node inside a pon node, to conform to dt schema. > >> > >> Signed-off-by: Rayyan Ansari <rayyan.ansari@linaro.org> > >> --- > >> arch/arm/boot/dts/qcom/pma8084.dtsi | 14 +++++++++----- > >> 1 file changed, 9 insertions(+), 5 deletions(-) > >> > >> diff --git a/arch/arm/boot/dts/qcom/pma8084.dtsi b/arch/arm/boot/dts/qcom/pma8084.dtsi > >> index 2985f4805b93..dbf7afcbfd8b 100644 > >> --- a/arch/arm/boot/dts/qcom/pma8084.dtsi > >> +++ b/arch/arm/boot/dts/qcom/pma8084.dtsi > >> @@ -19,12 +19,16 @@ rtc@6000 { > >> interrupts = <0x0 0x61 0x1 IRQ_TYPE_EDGE_RISING>; > >> }; > >> > >> - pwrkey@800 { > >> - compatible = "qcom,pm8941-pwrkey"; > >> + pon@800 { > >> + compatible = "qcom,pm8941-pon"; > >> reg = <0x800>; > >> - interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>; > >> - debounce = <15625>; > >> - bias-pull-up; > >> + > >> + pwrkey { > >> + compatible = "qcom,pm8941-pwrkey"; > >> + interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>; > >> + debounce = <15625>; > >> + bias-pull-up; > >> + }; > > > > It might be worth adding the resin node too, see pm8941.dtsi > > This is a cleanup series, adding features is another thing and it > would be nice if somebody could test it Agreed.
diff --git a/arch/arm/boot/dts/qcom/pma8084.dtsi b/arch/arm/boot/dts/qcom/pma8084.dtsi index 2985f4805b93..dbf7afcbfd8b 100644 --- a/arch/arm/boot/dts/qcom/pma8084.dtsi +++ b/arch/arm/boot/dts/qcom/pma8084.dtsi @@ -19,12 +19,16 @@ rtc@6000 { interrupts = <0x0 0x61 0x1 IRQ_TYPE_EDGE_RISING>; }; - pwrkey@800 { - compatible = "qcom,pm8941-pwrkey"; + pon@800 { + compatible = "qcom,pm8941-pon"; reg = <0x800>; - interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>; - debounce = <15625>; - bias-pull-up; + + pwrkey { + compatible = "qcom,pm8941-pwrkey"; + interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>; + debounce = <15625>; + bias-pull-up; + }; }; pma8084_gpios: gpio@c000 {
Wrap existing pwrkey node inside a pon node, to conform to dt schema. Signed-off-by: Rayyan Ansari <rayyan.ansari@linaro.org> --- arch/arm/boot/dts/qcom/pma8084.dtsi | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-)