diff mbox series

[1/2] drivers: drm/msm/a6xx_catalog: Add A642L speedbin (0x81)

Message ID 20240722184314.36510-2-danila@jiaxyga.com (mailing list archive)
State Superseded
Headers show
Series Add Qualcomm Adreno 642L speedbin and update SC7280 OPPs | expand

Commit Message

Danila Tikhonov July 22, 2024, 6:43 p.m. UTC
From: Eugene Lepshy <fekz115@gmail.com>

According to downstream, A642L's speedbin is 129 and uses 4 as index

Signed-off-by: Eugene Lepshy <fekz115@gmail.com>
Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
---
 drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Konrad Dybcio July 23, 2024, 11:18 a.m. UTC | #1
On 22.07.2024 8:43 PM, Danila Tikhonov wrote:
> From: Eugene Lepshy <fekz115@gmail.com>
> 
> According to downstream, A642L's speedbin is 129 and uses 4 as index
> 
> Signed-off-by: Eugene Lepshy <fekz115@gmail.com>
> Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
Bjorn Andersson July 29, 2024, 3:09 a.m. UTC | #2
On Mon, Jul 22, 2024 at 09:43:13PM GMT, Danila Tikhonov wrote:
> From: Eugene Lepshy <fekz115@gmail.com>
> 

Please make sure the subject prefix matches other changes in the same
driver/files.

Regards,
Bjorn

> According to downstream, A642L's speedbin is 129 and uses 4 as index
> 
> Signed-off-by: Eugene Lepshy <fekz115@gmail.com>
> Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
> ---
>  drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c b/drivers/gpu/drm/msm/adreno/a6xx_catalog.c
> index 68ba9aed5506e..99f0ee1a2edea 100644
> --- a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c
> +++ b/drivers/gpu/drm/msm/adreno/a6xx_catalog.c
> @@ -869,6 +869,7 @@ static const struct adreno_info a6xx_gpus[] = {
>  		.speedbins = ADRENO_SPEEDBINS(
>  			{ 0,   0 },
>  			{ 117, 0 },
> +			{ 129, 4 },
>  			{ 172, 2 }, /* Called speedbin 1 downstream, but let's not break things! */
>  			{ 190, 1 },
>  		),
> -- 
> 2.45.2
>
Danila Tikhonov July 29, 2024, 8:57 p.m. UTC | #3
On 7/29/24 06:09, Bjorn Andersson wrote:
> On Mon, Jul 22, 2024 at 09:43:13PM GMT, Danila Tikhonov wrote:
>> From: Eugene Lepshy <fekz115@gmail.com>
>>
> Please make sure the subject prefix matches other changes in the same
> driver/files.
>
> Regards,
> Bjorn
>

Thanks for the advice

"drm/msm/a6xx: --//--" will be better?

Best wishes,
Danila
diff mbox series

Patch

diff --git a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c b/drivers/gpu/drm/msm/adreno/a6xx_catalog.c
index 68ba9aed5506e..99f0ee1a2edea 100644
--- a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c
+++ b/drivers/gpu/drm/msm/adreno/a6xx_catalog.c
@@ -869,6 +869,7 @@  static const struct adreno_info a6xx_gpus[] = {
 		.speedbins = ADRENO_SPEEDBINS(
 			{ 0,   0 },
 			{ 117, 0 },
+			{ 129, 4 },
 			{ 172, 2 }, /* Called speedbin 1 downstream, but let's not break things! */
 			{ 190, 1 },
 		),