diff mbox series

soc: qcom: pd-mapper: Depend on ARCH_QCOM || COMPILE_TEST

Message ID 20240725-pd-mapper-config-v1-1-f26e513608c6@redhat.com (mailing list archive)
State Accepted
Commit e4ab5d7cb5f19858305395e034f214c92afc3cf5
Headers show
Series soc: qcom: pd-mapper: Depend on ARCH_QCOM || COMPILE_TEST | expand

Commit Message

Andrew Halaney July 25, 2024, 4:23 p.m. UTC
The pd-mapper driver doesn't make sense on non Qualcomm systems. Let's
follow suit with the rest of the Qualcomm SoC Kconfigs and depend on
ARCH_QCOM || COMPILE_TEST to avoid asking users about a config they will
not use.

Fixes: 1ebcde047c54 ("soc: qcom: add pd-mapper implementation")
Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
---
I *think* this makes sense, but please let me know if you think I'm
wrong. I was dealing with sorting out new configs for fedora and noticed
this was being asked for x86, etc, which didn't seem right to me.
---
 drivers/soc/qcom/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


---
base-commit: 2347b4c79f5e6cd3f4996e80c2d3c15f53006bf5
change-id: 20240725-pd-mapper-config-1495b150f738

Best regards,

Comments

Dmitry Baryshkov July 25, 2024, 6:46 p.m. UTC | #1
On Thu, 25 Jul 2024 at 19:23, Andrew Halaney <ahalaney@redhat.com> wrote:
>
> The pd-mapper driver doesn't make sense on non Qualcomm systems. Let's
> follow suit with the rest of the Qualcomm SoC Kconfigs and depend on
> ARCH_QCOM || COMPILE_TEST to avoid asking users about a config they will
> not use.
>
> Fixes: 1ebcde047c54 ("soc: qcom: add pd-mapper implementation")
> Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
> ---
> I *think* this makes sense, but please let me know if you think I'm
> wrong. I was dealing with sorting out new configs for fedora and noticed
> this was being asked for x86, etc, which didn't seem right to me.
> ---
>  drivers/soc/qcom/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I think this makes sense.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Bjorn Andersson July 29, 2024, 3:58 a.m. UTC | #2
On Thu, 25 Jul 2024 11:23:33 -0500, Andrew Halaney wrote:
> The pd-mapper driver doesn't make sense on non Qualcomm systems. Let's
> follow suit with the rest of the Qualcomm SoC Kconfigs and depend on
> ARCH_QCOM || COMPILE_TEST to avoid asking users about a config they will
> not use.
> 
> 

Applied, thanks!

[1/1] soc: qcom: pd-mapper: Depend on ARCH_QCOM || COMPILE_TEST
      commit: e4ab5d7cb5f19858305395e034f214c92afc3cf5

Best regards,
diff mbox series

Patch

diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
index 7f02f05259331..74b9121240f89 100644
--- a/drivers/soc/qcom/Kconfig
+++ b/drivers/soc/qcom/Kconfig
@@ -77,7 +77,7 @@  config QCOM_PD_MAPPER
 	select QCOM_QMI_HELPERS
 	select QCOM_PDR_MSG
 	select AUXILIARY_BUS
-	depends on NET && QRTR
+	depends on NET && QRTR && (ARCH_QCOM || COMPILE_TEST)
 	default QCOM_RPROC_COMMON
 	help
 	  The Protection Domain Mapper maps registered services to the domains