diff mbox series

[v3,1/2] dt-bindings: arm: qcom: Add LG G4 (h815)

Message ID 20240727201413.114317-2-alexander.reimelt@posteo.de (mailing list archive)
State Accepted
Commit d2e577267cc29841d9f316ff65494d1892fed13c
Headers show
Series arm64: Add basic support for LG H815 | expand

Commit Message

Alexander Reimelt July 27, 2024, 8:04 p.m. UTC
International variant of the LG G4 from 2015.

Signed-off-by: Alexander Reimelt <alexander.reimelt@posteo.de>
---
 Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski July 28, 2024, 8:42 a.m. UTC | #1
On 27/07/2024 22:04, Alexander Reimelt wrote:
> International variant of the LG G4 from 2015.
> 
> Signed-off-by: Alexander Reimelt <alexander.reimelt@posteo.de>
> ---

<form letter>
This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions, under or above your Signed-off-by tag. Tag is "received", when
provided in a message replied to you on the mailing list. Tools like b4
can help here. However, there's no need to repost patches *only* to add
the tags. The upstream maintainer will do that for tags received on the
version they apply.

https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577

If a tag was not added on purpose, please state why and what changed.
</form letter>

Best regards,
Krzysztof
Petr Vorel July 28, 2024, 3:13 p.m. UTC | #2
Hi all,

> International variant of the LG G4 from 2015.

Obviously correct.
Reviewed-by: Petr Vorel <petr.vorel@gmail.com>

Alexander, others have added their tags in previous versions. IMHO generally
it'd be worth if you carry others tags in next versions (when nothing changes).

I now see Krzysztof was faster to write this. Thus I put the tags with links:

https://lore.kernel.org/linux-arm-msm/171216461463.4018435.3466905061314737419.robh@kernel.org/
Acked-by: Rob Herring <robh@kernel.org>

https://lore.kernel.org/linux-arm-msm/d596abcd-8374-4a6f-ad98-c5a04416865d@linaro.org/
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Kind regards,
Petr

> Signed-off-by: Alexander Reimelt <alexander.reimelt@posteo.de>
> ---
>  Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
>  1 file changed, 1 insertion(+)

> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index f08e13b61172..f79730d02eb7 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -250,6 +250,7 @@ properties:
>        - items:
>            - enum:
>                - lg,bullhead
> +              - lg,h815
>                - microsoft,talkman
>                - xiaomi,libra
>            - const: qcom,msm8992
Alexander Reimelt July 28, 2024, 6:59 p.m. UTC | #3
Hello,

> Alexander, others have added their tags in previous versions. IMHO generally
> it'd be worth if you carry others tags in next versions (when nothing
> changes).
I already replied to Krzysztof, but I messed it up and sent it only to him. 
I'm sorry I wasted everyone's time. I didn't fully understand how the system 
behind these tags worked until now. I should have asked earlier, but thanks 
for pointing it out.

Kind regards,
Alexander
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index f08e13b61172..f79730d02eb7 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -250,6 +250,7 @@  properties:
       - items:
           - enum:
               - lg,bullhead
+              - lg,h815
               - microsoft,talkman
               - xiaomi,libra
           - const: qcom,msm8992