| Message ID | 20240806-add_qcs9100_soc_id-v1-3-04d14081f304@quicinc.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | soc: qcom: Add QCS9100 SoC ID and compatible support | expand |
On 06/08/2024 06:19, Tengfei Fan wrote:
> Add the compatible for QCS9100 SoC.
Standard reply: we see that from the diff. Oh wait, no! The diff is
doing something entirely else.
You do much more - change SA8775p bindings.
Commit msg should say why you are doing such invasive change.
Best regards,
Krzysztof
On 8/7/2024 3:27 PM, Krzysztof Kozlowski wrote: > On 06/08/2024 06:19, Tengfei Fan wrote: >> Add the compatible for QCS9100 SoC. > > Standard reply: we see that from the diff. Oh wait, no! The diff is > doing something entirely else. > > You do much more - change SA8775p bindings. > > Commit msg should say why you are doing such invasive change. > > Best regards, > Krzysztof > I will explain the reason why change SA8775p bindings for support QCS9100 in the commit message of the next version patch series.
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml index f08e13b61172..71368b08eab8 100644 --- a/Documentation/devicetree/bindings/arm/qcom.yaml +++ b/Documentation/devicetree/bindings/arm/qcom.yaml @@ -43,6 +43,7 @@ description: | msm8998 qcs404 qcs8550 + qcs9100 qcm2290 qcm6490 qdu1000 @@ -900,6 +901,7 @@ properties: - qcom,sa8775p-ride - qcom,sa8775p-ride-r3 - const: qcom,sa8775p + - const: qcom,qcs9100 - items: - enum:
Add the compatible for QCS9100 SoC. Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> --- Documentation/devicetree/bindings/arm/qcom.yaml | 2 ++ 1 file changed, 2 insertions(+)