| Message ID | 20240829-x1e80100-combo-qmpphys-add-orientation-switch-v1-1-5c61ea1794da@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 17c5909f53e01c151c91f66949a9c4f191756bae |
| Headers | show |
| Series | arm64: dts: qcom: x1e80100: Add orientation-switch to all USB+DP QMP PHYs | expand |
On 29.08.2024 1:44 PM, Abel Vesa wrote: > All three USB SS combo QMP PHYs need to power off, deinit, then init and > power on again on every plug in event. This is done by forwarding the > orientation from the retimer/mux to the PHY. All is needed is the > orientation-switch property in each such PHY devicetree node. So add > them. > > Fixes: 4af46b7bd66f ("arm64: dts: qcom: x1e80100: Add USB nodes") > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > --- Reviewed-by: Konrad Dybcio <konradybcio@kernel.org> Konrad
On Thu, 29 Aug 2024 14:44:47 +0300, Abel Vesa wrote: > All three USB SS combo QMP PHYs need to power off, deinit, then init and > power on again on every plug in event. This is done by forwarding the > orientation from the retimer/mux to the PHY. All is needed is the > orientation-switch property in each such PHY devicetree node. So add > them. > > > [...] Applied, thanks! [1/1] arm64: dts: qcom: x1e80100: Add orientation-switch to all USB+DP QMP PHYs commit: 17c5909f53e01c151c91f66949a9c4f191756bae Best regards,
diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi index 6abff8258674..8a577f29d4d4 100644 --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi @@ -2604,6 +2604,8 @@ usb_1_ss0_qmpphy: phy@fd5000 { #clock-cells = <1>; #phy-cells = <1>; + orientation-switch; + status = "disabled"; ports { @@ -2672,6 +2674,8 @@ usb_1_ss1_qmpphy: phy@fda000 { #clock-cells = <1>; #phy-cells = <1>; + orientation-switch; + status = "disabled"; ports { @@ -2740,6 +2744,8 @@ usb_1_ss2_qmpphy: phy@fdf000 { #clock-cells = <1>; #phy-cells = <1>; + orientation-switch; + status = "disabled"; ports {
All three USB SS combo QMP PHYs need to power off, deinit, then init and power on again on every plug in event. This is done by forwarding the orientation from the retimer/mux to the PHY. All is needed is the orientation-switch property in each such PHY devicetree node. So add them. Fixes: 4af46b7bd66f ("arm64: dts: qcom: x1e80100: Add USB nodes") Signed-off-by: Abel Vesa <abel.vesa@linaro.org> --- arch/arm64/boot/dts/qcom/x1e80100.dtsi | 6 ++++++ 1 file changed, 6 insertions(+) --- base-commit: b18bbfc14a38b5234e09c2adcf713e38063a7e6e change-id: 20240829-x1e80100-combo-qmpphys-add-orientation-switch-afc7f6f25137 Best regards,