diff mbox series

arm: expressatt: fix pm8921_l6 regulator

Message ID 20240916-sd-card-regulator-v1-1-669533c393d7@gmail.com (mailing list archive)
State New
Headers show
Series arm: expressatt: fix pm8921_l6 regulator | expand

Commit Message

Rudraksha Gupta via B4 Relay Sept. 17, 2024, 4:48 a.m. UTC 
From: Rudraksha Gupta <guptarud@gmail.com>

The SD card refuses to work because the regulator is turned off. Enable
it by default.

Signed-off-by: Rudraksha Gupta <guptarud@gmail.com>
---
 arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts | 1 +
 1 file changed, 1 insertion(+)


---
base-commit: 98f7e32f20d28ec452afb208f9cffc08448a2652
change-id: 20240916-sd-card-regulator-a71268ca47e8

Best regards,

Comments

Krzysztof Kozlowski Sept. 17, 2024, 6:02 a.m. UTC | #1 
On 17/09/2024 06:48, Rudraksha Gupta via B4 Relay wrote:
> From: Rudraksha Gupta <guptarud@gmail.com>
> 
> The SD card refuses to work because the regulator is turned off. Enable
> it by default.

That's odd. Are you sure regulator is provided in SD card node? Is it
SDCC1 or SDCC3?

Best regards,
Krzysztof
Rudraksha Gupta Sept. 17, 2024, 7:51 a.m. UTC | #2 
> That's odd. Are you sure regulator is provided in SD card node? Is it
> SDCC1 or SDCC3?

I believe it's SDCC3. Unfortunately, I don't think this patch is the 
solution either anymore. It was working with this patch consistently, 
but now my phone just hangs on mounting the SD card like before. I've 
tried a combination of GPT and MSDOS + vfat, ext2, and ext4. I'm not 
sure what I'm doing wrong cause the SD card consistently works on the 
downstream Linux kernel :(

Sorry for wasting your time


Thanks,

Rudraksha
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts b/arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts
index af6cc6393d74..13c102a562ab 100644
--- a/arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts
+++ b/arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts
@@ -253,6 +253,7 @@  pm8921_l5: l5 {
 		};
 
 		pm8921_l6: l6 {
+			regulator-always-on;
 			regulator-min-microvolt = <2950000>;
 			regulator-max-microvolt = <2950000>;
 			bias-pull-down;