| Message ID | 20240926231038.31916-1-minhuadotchen@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | regulator: qcom-smd: make smd_vreg_rpm static | expand |
On Fri, Sep 27, 2024 at 07:10:36AM GMT, Min-Hua Chen wrote: > Since smd_vreg_rpm is used only in > drivers/regulator/qcom_smd-regulator.c, make it static and fix the > following sparse warning: > > drivers/regulator/qcom_smd-regulator.c:14:21: sparse: warning: > symbol 'smd_vreg_rpm' was not declared. Should it be static? > > No functional changes intended. > > Fixes: 5df3b41bd6b5 ("regulator: qcom_smd: Keep one rpm handle for all vregs") > Signed-off-by: Min-Hua Chen <minhuadotchen@gmail.com> > --- > drivers/regulator/qcom_smd-regulator.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
diff --git a/drivers/regulator/qcom_smd-regulator.c b/drivers/regulator/qcom_smd-regulator.c index 28e7ce60cb61..25ed9f713974 100644 --- a/drivers/regulator/qcom_smd-regulator.c +++ b/drivers/regulator/qcom_smd-regulator.c @@ -11,7 +11,7 @@ #include <linux/regulator/of_regulator.h> #include <linux/soc/qcom/smd-rpm.h> -struct qcom_smd_rpm *smd_vreg_rpm; +static struct qcom_smd_rpm *smd_vreg_rpm; struct qcom_rpm_reg { struct device *dev;
Since smd_vreg_rpm is used only in drivers/regulator/qcom_smd-regulator.c, make it static and fix the following sparse warning: drivers/regulator/qcom_smd-regulator.c:14:21: sparse: warning: symbol 'smd_vreg_rpm' was not declared. Should it be static? No functional changes intended. Fixes: 5df3b41bd6b5 ("regulator: qcom_smd: Keep one rpm handle for all vregs") Signed-off-by: Min-Hua Chen <minhuadotchen@gmail.com> --- drivers/regulator/qcom_smd-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)