| Message ID | 20241011052315.4713-1-everestkc@everestkc.com.np (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [next] drm/msm/a6xx: Remove logically deadcode in a6xx_preempt.c | expand |
On Thu, Oct 10, 2024 at 11:23:14PM -0600, Everest K.C. wrote: > The ternary operator never returns -1 as `ring` will never be NULL. > Thus, the ternary operator is not needed. > Fix this by removing the ternary operation and only including the > value it will return when the `ring` is not NULL. > > This was reported by Coverity Scan. > https://scan7.scan.coverity.com/#/project-view/51525/11354?selectedIssue=1600286 > > Fixes: 35d36dc1692f ("drm/msm/a6xx: Add traces for preemption") > Signed-off-by: Everest K.C. <everestkc@everestkc.com.np> > --- Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org> regards, dan carpenter
diff --git a/drivers/gpu/drm/msm/adreno/a6xx_preempt.c b/drivers/gpu/drm/msm/adreno/a6xx_preempt.c index 6803d5af60cc..2fd4e39f618f 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_preempt.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_preempt.c @@ -297,8 +297,7 @@ void a6xx_preempt_trigger(struct msm_gpu *gpu) */ ring->restore_wptr = false; - trace_msm_gpu_preemption_trigger(a6xx_gpu->cur_ring->id, - ring ? ring->id : -1); + trace_msm_gpu_preemption_trigger(a6xx_gpu->cur_ring->id, ring->id); spin_unlock_irqrestore(&ring->preempt_lock, flags);
The ternary operator never returns -1 as `ring` will never be NULL. Thus, the ternary operator is not needed. Fix this by removing the ternary operation and only including the value it will return when the `ring` is not NULL. This was reported by Coverity Scan. https://scan7.scan.coverity.com/#/project-view/51525/11354?selectedIssue=1600286 Fixes: 35d36dc1692f ("drm/msm/a6xx: Add traces for preemption") Signed-off-by: Everest K.C. <everestkc@everestkc.com.np> --- drivers/gpu/drm/msm/adreno/a6xx_preempt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)