diff mbox series

[3/4] drm/msm/dp: replace ST_DISPLAY_OFF with power_on in msm_dp_hpd_unplug_handle()

Message ID 20241202-hpd_display_off-v1-3-8d0551847753@quicinc.com (mailing list archive)
State Not Applicable
Headers show
Series drm/msm/dp: ST_DISPLAY_OFF hpd cleanup | expand

Commit Message

Abhinav Kumar Dec. 3, 2024, 12:39 a.m. UTC
msm_dp_hpd_unplug_handle() checks if the display was already disabled and if
so does not transition to ST_DISCONNECT_PENDING state and goes directly to
ST_DISCONNECTED. The same result can be achieved with the !power_on check.

Replace ST_DISPLAY_OFF with !power_on to achieve the same outcome.

Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
---
 drivers/gpu/drm/msm/dp/dp_display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Dmitry Baryshkov Dec. 3, 2024, 1:53 p.m. UTC | #1
On Mon, Dec 02, 2024 at 04:39:02PM -0800, Abhinav Kumar wrote:
> msm_dp_hpd_unplug_handle() checks if the display was already disabled and if
> so does not transition to ST_DISCONNECT_PENDING state and goes directly to
> ST_DISCONNECTED. The same result can be achieved with the !power_on check.
> 
> Replace ST_DISPLAY_OFF with !power_on to achieve the same outcome.
> 
> Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
> ---
>  drivers/gpu/drm/msm/dp/dp_display.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
index 614fff09e5f2..831876aa5b35 100644
--- a/drivers/gpu/drm/msm/dp/dp_display.c
+++ b/drivers/gpu/drm/msm/dp/dp_display.c
@@ -655,7 +655,7 @@  static int msm_dp_hpd_unplug_handle(struct msm_dp_display_private *dp, u32 data)
 	 */
 	msm_dp_display_notify_disconnect(&dp->msm_dp_display.pdev->dev);
 
-	if (state == ST_DISPLAY_OFF) {
+	if (!dp->msm_dp_display.power_on) {
 		dp->hpd_state = ST_DISCONNECTED;
 	} else {
 		dp->hpd_state = ST_DISCONNECT_PENDING;