| Message ID | 20241204-topic-misc-dt-fixes-v1-3-6d320b6454e6@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm64: dts: qcom: misc DT bindings check fixes | expand |
Hi, On Wed, Dec 4, 2024 at 2:57 AM Neil Armstrong <neil.armstrong@linaro.org> wrote: > > The bindings requires the avee-supply, use the same regulator as > the avdd (positive voltage) which would also provide the negative > voltage by definition. > > The fixes: > sc7180-trogdor-quackingstick-r0.dts: panel@0: 'avee-supply' is a required property > from schema $id: http://devicetree.org/schemas/display/panel/boe,tv101wum-nl6.yaml# > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > --- > arch/arm64/boot/dts/qcom/sc7180-trogdor-quackingstick.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-quackingstick.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-quackingstick.dtsi > index 00229b1515e60505f15fd58c6e7f16dcbf9c661b..ff8996b4de4e1e66a0f2aac0180233640602caf3 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-quackingstick.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-quackingstick.dtsi > @@ -78,6 +78,7 @@ panel: panel@0 { > pinctrl-names = "default"; > pinctrl-0 = <&lcd_rst>; > avdd-supply = <&ppvar_lcd>; > + avee-supply = <&ppvar_lcd>; Looks right. I guess technically they could be modeled as two regulators, but it feels pointless. Looking at the schematics there is a single component on the board that provides both the positive and negative voltages. There are two enable lines on the component but they're tied together on the board so we can't enable one separately from the other anyway. Thanks for the fix! Reviewed-by: Douglas Anderson <dianders@chromium.org>
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-quackingstick.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-quackingstick.dtsi index 00229b1515e60505f15fd58c6e7f16dcbf9c661b..ff8996b4de4e1e66a0f2aac0180233640602caf3 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-quackingstick.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-quackingstick.dtsi @@ -78,6 +78,7 @@ panel: panel@0 { pinctrl-names = "default"; pinctrl-0 = <&lcd_rst>; avdd-supply = <&ppvar_lcd>; + avee-supply = <&ppvar_lcd>; pp1800-supply = <&v1p8_disp>; pp3300-supply = <&pp3300_dx_edp>; backlight = <&backlight>;
The bindings requires the avee-supply, use the same regulator as the avdd (positive voltage) which would also provide the negative voltage by definition. The fixes: sc7180-trogdor-quackingstick-r0.dts: panel@0: 'avee-supply' is a required property from schema $id: http://devicetree.org/schemas/display/panel/boe,tv101wum-nl6.yaml# Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> --- arch/arm64/boot/dts/qcom/sc7180-trogdor-quackingstick.dtsi | 1 + 1 file changed, 1 insertion(+)