Message ID | 20241210-x1e80100-usb-qmp-supply-fix-v1-3-0adda5d30bbd@linaro.org (mailing list archive) |
---|---|
State | Queued |
Headers | show |
Series | arm64: dts: qcom: x1e*: Fix USB QMP PHY supplies | expand |
On 12/10/24 10:07, Stephan Gerhold wrote: > On the X1E80100 CRD, &vreg_l3e_1p2 only powers &usb_mp_qmpphy0/1 > (i.e. USBSS_3 and USBSS_4). The QMP PHYs for USB_0, USB_1 and USB_2 > are actually powered by &vreg_l2j_1p2. > > Since x1e80100-asus-vivobook-s15 mostly just mirrors the power supplies > from the x1e80100-crd device tree, assume that the fix also applies here. > > Cc: stable@vger.kernel.org > Fixes: d0e2f8f62dff ("arm64: dts: qcom: Add device tree for ASUS Vivobook S 15") > Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org> > --- > arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts b/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts > index f25991b887de3fca0092c5f81c881c5d8bd71aac..bcb25782d541f43166229695ea1b83ee7b94a6c8 100644 > --- a/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts > +++ b/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts > @@ -599,7 +599,7 @@ &usb_1_ss0_hsphy { > }; > > &usb_1_ss0_qmpphy { > - vdda-phy-supply = <&vreg_l3e_1p2>; > + vdda-phy-supply = <&vreg_l2j_1p2>; > vdda-pll-supply = <&vreg_l1j_0p8>; > > status = "okay"; > @@ -631,7 +631,7 @@ &usb_1_ss1_hsphy { > }; > > &usb_1_ss1_qmpphy { > - vdda-phy-supply = <&vreg_l3e_1p2>; > + vdda-phy-supply = <&vreg_l2j_1p2>; > vdda-pll-supply = <&vreg_l2d_0p9>; > > status = "okay"; > I can't really verify with documentation if it is actually correct but given the similarities in all these systems I have no reason to assume not. It doesn't seem to cause any weird errors or anything, so Tested-by: Maud Spierings <maud_spierings@hotmail.com>
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts b/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts index f25991b887de3fca0092c5f81c881c5d8bd71aac..bcb25782d541f43166229695ea1b83ee7b94a6c8 100644 --- a/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts +++ b/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts @@ -599,7 +599,7 @@ &usb_1_ss0_hsphy { }; &usb_1_ss0_qmpphy { - vdda-phy-supply = <&vreg_l3e_1p2>; + vdda-phy-supply = <&vreg_l2j_1p2>; vdda-pll-supply = <&vreg_l1j_0p8>; status = "okay"; @@ -631,7 +631,7 @@ &usb_1_ss1_hsphy { }; &usb_1_ss1_qmpphy { - vdda-phy-supply = <&vreg_l3e_1p2>; + vdda-phy-supply = <&vreg_l2j_1p2>; vdda-pll-supply = <&vreg_l2d_0p9>; status = "okay";
On the X1E80100 CRD, &vreg_l3e_1p2 only powers &usb_mp_qmpphy0/1 (i.e. USBSS_3 and USBSS_4). The QMP PHYs for USB_0, USB_1 and USB_2 are actually powered by &vreg_l2j_1p2. Since x1e80100-asus-vivobook-s15 mostly just mirrors the power supplies from the x1e80100-crd device tree, assume that the fix also applies here. Cc: stable@vger.kernel.org Fixes: d0e2f8f62dff ("arm64: dts: qcom: Add device tree for ASUS Vivobook S 15") Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org> --- arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)