| Message ID | 20241210111444.26240-3-johan+linaro@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2e5e1a7ea692dc2b9f1acf0ebeb75bc282733cac |
| Headers | show |
| Series | arm64: dts: qcom: x1e80100: fix USB OTG regressions | expand |
On 24-12-10 12:14:43, Johan Hovold wrote: > This reverts commit 2dd3250191bcfe93b0c9da46624af830310400a7. > > A recent change enabling OTG mode on the x1e81000 CRD breaks suspend. > Specifically, the device hard resets during resume if suspended with all > controllers in device mode (i.e. no USB device connected). > > The corresponding change on the T14s also led to SuperSpeed hotplugs not > being detected. > > With retimer (and orientation detection) support not even merged yet, > let's revert at least until we have stable host mode in mainline. > > Fixes: 2dd3250191bc ("arm64: dts: qcom: x1e80100-crd: enable otg on usb ports") > Reported-by: Abel Vesa <abel.vesa@linaro.org> > Cc: Jonathan Marek <jonathan@marek.ca> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> Reviewed-by: Abel Vesa <abel.vesa@linaro.org> > --- > arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts > index 199f6b42aa11..66360390ae7d 100644 > --- a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts > +++ b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts > @@ -1840,6 +1840,10 @@ &usb_1_ss0 { > status = "okay"; > }; > > +&usb_1_ss0_dwc3 { > + dr_mode = "host"; > +}; > + > &usb_1_ss0_dwc3_hs { > remote-endpoint = <&pmic_glink_ss0_hs_in>; > }; > @@ -1868,6 +1872,10 @@ &usb_1_ss1 { > status = "okay"; > }; > > +&usb_1_ss1_dwc3 { > + dr_mode = "host"; > +}; > + > &usb_1_ss1_dwc3_hs { > remote-endpoint = <&pmic_glink_ss1_hs_in>; > }; > @@ -1896,6 +1904,10 @@ &usb_1_ss2 { > status = "okay"; > }; > > +&usb_1_ss2_dwc3 { > + dr_mode = "host"; > +}; > + > &usb_1_ss2_dwc3_hs { > remote-endpoint = <&pmic_glink_ss2_hs_in>; > }; > -- > 2.45.2 >
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts index 199f6b42aa11..66360390ae7d 100644 --- a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts +++ b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts @@ -1840,6 +1840,10 @@ &usb_1_ss0 { status = "okay"; }; +&usb_1_ss0_dwc3 { + dr_mode = "host"; +}; + &usb_1_ss0_dwc3_hs { remote-endpoint = <&pmic_glink_ss0_hs_in>; }; @@ -1868,6 +1872,10 @@ &usb_1_ss1 { status = "okay"; }; +&usb_1_ss1_dwc3 { + dr_mode = "host"; +}; + &usb_1_ss1_dwc3_hs { remote-endpoint = <&pmic_glink_ss1_hs_in>; }; @@ -1896,6 +1904,10 @@ &usb_1_ss2 { status = "okay"; }; +&usb_1_ss2_dwc3 { + dr_mode = "host"; +}; + &usb_1_ss2_dwc3_hs { remote-endpoint = <&pmic_glink_ss2_hs_in>; };
This reverts commit 2dd3250191bcfe93b0c9da46624af830310400a7. A recent change enabling OTG mode on the x1e81000 CRD breaks suspend. Specifically, the device hard resets during resume if suspended with all controllers in device mode (i.e. no USB device connected). The corresponding change on the T14s also led to SuperSpeed hotplugs not being detected. With retimer (and orientation detection) support not even merged yet, let's revert at least until we have stable host mode in mainline. Fixes: 2dd3250191bc ("arm64: dts: qcom: x1e80100-crd: enable otg on usb ports") Reported-by: Abel Vesa <abel.vesa@linaro.org> Cc: Jonathan Marek <jonathan@marek.ca> Signed-off-by: Johan Hovold <johan+linaro@kernel.org> --- arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 12 ++++++++++++ 1 file changed, 12 insertions(+)