From patchwork Tue Dec 10 11:14:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 13901331 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E9CB1DC998; Tue, 10 Dec 2024 11:15:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733829333; cv=none; b=XROf0Q4kUbjeULyadbeMqwOaFeRYqksIT0gmYXvqrBg6cBjzL1X4uLOv6zHGmJlRsAPvEq3fuwz/4rCf9RXDQdrdufSvREPS3mW0dR9YOFRcHqBKnjINgs1BDumiOmctVFWlb5Kph97q13hN2AqTOId4vrGKEsc9Z3obOpW98pA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733829333; c=relaxed/simple; bh=L5GszgCqF7LF91WytrVze1o325SqKK7siXqfCAphg8o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=vANOLqqTjPNxAczGlFF0o4xxFgWu+T+33MRt3KArfE6T0Bz00LZgB+hTGmBNJiszp/42fXnod/O86m4/YJzg3lqyFL/o4WF2Ely7CP86+UK8Qh3o3az5IeTdHlUN7XT3kpSeUZWFycbxO4dzNTSRaweV7tqKqhyYD03ztUH1bvk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XWGeXlYy; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XWGeXlYy" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 08B82C4CEE1; Tue, 10 Dec 2024 11:15:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1733829333; bh=L5GszgCqF7LF91WytrVze1o325SqKK7siXqfCAphg8o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XWGeXlYyjKaptStKljVza2s2LLXqYEJ2ql9iD+F1/Tc9RkpILl9SwxUM+IO/VJcKm SnGhgVAwB6rgl8/V0PHk2/LTCXQNFvJU07dBJif1FUeXZaE43LKvwLAEFt0WNgtmvk dIjx1kPii1WGsBkxNOTsKsv3PdK56BRqBag12Ctx86hxXe8simkO9UCRLQdlmlww2s ISdVEQiudx8RaKMNC7MZsVRW8swO8AniHjkIpe5dBq0GRHMFGiXz7mDAmWcJ3hpWoN syYkuKwC3jeBCJPrFfwUWyzPoIodTdLBeoQ17+76pNlaaPdXIZgqoEBZtK0DF1roQj DkY+OFV9T+yTw== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1tKyDH-000000006qx-28JG; Tue, 10 Dec 2024 12:15:35 +0100 From: Johan Hovold To: Bjorn Andersson , Konrad Dybcio Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Baryshkov , Jonathan Marek , Stephan Gerhold , Abel Vesa , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, regressions@lists.linux.dev, Johan Hovold Subject: [PATCH v3 3/3] Revert "arm64: dts: qcom: x1e80100: enable OTG on USB-C controllers" Date: Tue, 10 Dec 2024 12:14:44 +0100 Message-ID: <20241210111444.26240-4-johan+linaro@kernel.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241210111444.26240-1-johan+linaro@kernel.org> References: <20241210111444.26240-1-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This reverts commit f042bc234c2e00764b8aa2c9e2f8177cdc63f664. A recent change enabling role switching for the x1e80100 USB-C controllers breaks UCSI and DisplayPort Alternate Mode when the controllers are in host mode: ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: PPM init failed, stop trying As enabling OTG mode currently breaks SuperSpeed hotplug and suspend, and with retimer (and orientation detection) support not even merged yet, let's revert at least until we have stable host mode in mainline. Fixes: f042bc234c2e ("arm64: dts: qcom: x1e80100: enable OTG on USB-C controllers") Reported-by: Dmitry Baryshkov Link: https://lore.kernel.org/all/hw2pdof4ajadjsjrb44f2q4cz4yh5qcqz5d3l7gjt2koycqs3k@xx5xvd26uyef Link: https://lore.kernel.org/lkml/Z1gbyXk-SktGjL6-@hovoldconsulting.com/ Cc: Jonathan Marek Signed-off-by: Johan Hovold Reviewed-by: Abel Vesa --- arch/arm64/boot/dts/qcom/x1e80100.dtsi | 6 ------ 1 file changed, 6 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi index 1740fdf7b1de..4c1e01605e87 100644 --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi @@ -4422,8 +4422,6 @@ usb_1_ss2_dwc3: usb@a000000 { dma-coherent; - usb-role-switch; - ports { #address-cells = <1>; #size-cells = <0>; @@ -4677,8 +4675,6 @@ usb_1_ss0_dwc3: usb@a600000 { dma-coherent; - usb-role-switch; - ports { #address-cells = <1>; #size-cells = <0>; @@ -4777,8 +4773,6 @@ usb_1_ss1_dwc3: usb@a800000 { dma-coherent; - usb-role-switch; - ports { #address-cells = <1>; #size-cells = <0>;