diff mbox series

[v2,3/3] arm64: dts: qcom: x1e80100-lenovo-yoga-slim7x: Add the EC

Message ID 20241219200821.8328-3-maccraft123mc@gmail.com (mailing list archive)
State New
Headers show
Series [v2,1/3] dt-bindings: platform: Add bindings for Qcom's EC on IT8987 | expand

Commit Message

Maya Matuszczyk Dec. 19, 2024, 8:08 p.m. UTC
Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>
---
 .../dts/qcom/x1e80100-lenovo-yoga-slim7x.dts  | 22 +++++++++++++++++++
 1 file changed, 22 insertions(+)

Comments

Aiqun(Maria) Yu Dec. 20, 2024, 11:52 a.m. UTC | #1
On 12/20/2024 4:08 AM, Maya Matuszczyk wrote:
> Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>

Is the commit message missing for this patch?
> ---
>  .../dts/qcom/x1e80100-lenovo-yoga-slim7x.dts  | 22 +++++++++++++++++++
>  1 file changed, 22 insertions(+)
[...]
Konrad Dybcio Dec. 20, 2024, 12:10 p.m. UTC | #2
On 20.12.2024 12:52 PM, Aiqun(Maria) Yu wrote:
> On 12/20/2024 4:08 AM, Maya Matuszczyk wrote:
>> Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>
> 
> Is the commit message missing for this patch?

Yeah

Maya, please add a short summary (some backstory about the EC, what
it does or so).

You'll probably be asked to do the same with the bindings commit, but
you can mostly repeat the same thing both here and there.

Konrad
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
index 0cdaff9c8cf0..dfe009613b0c 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
@@ -538,6 +538,22 @@  keyboard@3a {
 	};
 };
 
+&i2c5 {
+	clock-frequency = <400000>;
+
+	status = "okay";
+
+	embedded-controller@76 {
+		compatible = "lenovo,yoga-slim7x-ec", "qcom,x1e-it8987-ec";
+		reg = <0x76>;
+
+		interrupts-extended = <&tlmm 66 IRQ_TYPE_EDGE_FALLING>;
+
+		pinctrl-0 = <&ec_int_n_default>;
+		pinctrl-names = "default";
+	};
+};
+
 &i2c8 {
 	clock-frequency = <400000>;
 
@@ -796,6 +812,12 @@  &tlmm {
 			       <44 4>, /* SPI (TPM) */
 			       <238 1>; /* UFS Reset */
 
+	ec_int_n_default: ec-int-n-state {
+		pins = "gpio66";
+		function = "gpio";
+		bias-disable;
+	};
+
 	edp_reg_en: edp-reg-en-state {
 		pins = "gpio70";
 		function = "gpio";