| Message ID | 20250113-schema_qcs615-v3-1-d5bbf0ee8cb7@quicinc.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v3] dt-bindings: net: qcom,ethqos: Correct fallback compatible for qcom,qcs615-ethqos | expand |
On Mon, Jan 13, 2025 at 05:15:39PM +0800, Yijie Yang wrote: > The qcs615-ride utilizes the same EMAC as the qcs404, rather than the > sm8150. > The current fallback could lead to package loss, and the ethernet on Packet? Package? > qcs615-ride was not utilized by anyone. I don't get how this part of sentence is connected to previous part. I see the "and" but what do you want to say here? Packages with qcs615 board were lost, therefore the ethernet was not used by anyone? Or packets could be lost and this means ethernet cannot be used? > Therefore, it needs to be revised, > and there is no need to worry about the ABI impact. Again, Oxford comma of joining entirely independent claues. Can you filter this via someone / ChatGPT / Google grammar / Outlook grammar? Best regards, Krzysztof
On 2025-01-14 16:03, Krzysztof Kozlowski wrote: > On Mon, Jan 13, 2025 at 05:15:39PM +0800, Yijie Yang wrote: >> The qcs615-ride utilizes the same EMAC as the qcs404, rather than the >> sm8150. >> The current fallback could lead to package loss, and the ethernet on > > Packet? Package? I made an error in word usage, and I will correct it. > >> qcs615-ride was not utilized by anyone. > > I don't get how this part of sentence is connected to previous part. I > see the "and" but what do you want to say here? Packages with qcs615 > board were lost, therefore the ethernet was not used by anyone? Or > packets could be lost and this means ethernet cannot be used? > The word 'and' represents two independent facts without implying a logical relationship between them. The two facts correspondingly lead to the two conclusions in the next sentence. >> Therefore, it needs to be revised, >> and there is no need to worry about the ABI impact. > > Again, Oxford comma of joining entirely independent claues. Can you > filter this via someone / ChatGPT / Google grammar / Outlook grammar? All the sentences here have been polished by Copilot. I will reorganize them for better understanding. > > Best regards, > Krzysztof > >
diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml index f117471fb06fb3b507df811d55d41d0b610ac15f..e7ee0d9efed8330f5cf62e6c0ea41066572415aa 100644 --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml @@ -22,12 +22,12 @@ properties: oneOf: - items: - enum: - - qcom,qcs8300-ethqos - - const: qcom,sa8775p-ethqos + - qcom,qcs615-ethqos + - const: qcom,qcs404-ethqos - items: - enum: - - qcom,qcs615-ethqos - - const: qcom,sm8150-ethqos + - qcom,qcs8300-ethqos + - const: qcom,sa8775p-ethqos - enum: - qcom,qcs404-ethqos - qcom,sa8775p-ethqos
The qcs615-ride utilizes the same EMAC as the qcs404, rather than the sm8150. The current fallback could lead to package loss, and the ethernet on qcs615-ride was not utilized by anyone. Therefore, it needs to be revised, and there is no need to worry about the ABI impact. Fixes: 32535b9410b8 ("dt-bindings: net: qcom,ethqos: add description for qcs615") Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com> --- Changes in v3: - Fallback the Ethernet compatible of qcs615 to that of qcs404. - Remove unnecessary patches. - Enrich the commit description to clarify the ABI impact. - Update the base commit to next-20250113. - Link to v2: https://lore.kernel.org/r/20241224-schema-v2-0-000ea9044c49@quicinc.com --- Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) --- base-commit: 12d614e5293b74345f6d0ed93620f8f10ce0f8b9 change-id: 20250113-schema_qcs615-bd7b3d82c2fa Best regards,