| Message ID | 20250209-fd-hdmi-hpd-v4-2-6224568ed87f@linaro.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | drm/msm/hdmi: rework and fix the HPD even generation | expand |
On Sun, Feb 09, 2025 at 07:04:46AM +0200, Dmitry Baryshkov wrote: > Supporting simultaneous check of native HPD and the external GPIO proved > to be less stable than just native HPD. Drop the hpd-gpios from the > bindings. This is not a breaking change, since the HDMI block has been > using both GPIO _and_ internal HPD anyway. In case the native HPD > doesn't work users are urged to switch to specifying the hpd-gpios > property to the hdmi-connector device. In that case users would need to update their DTS/DTB, so that's an ABI break. Please deprecate the property here (deprecated: true) and keep support in the driver. Best regards, Krzysztof
On Tue, Feb 11, 2025 at 09:26:31AM +0100, Krzysztof Kozlowski wrote: > On Sun, Feb 09, 2025 at 07:04:46AM +0200, Dmitry Baryshkov wrote: > > Supporting simultaneous check of native HPD and the external GPIO proved > > to be less stable than just native HPD. Drop the hpd-gpios from the > > bindings. This is not a breaking change, since the HDMI block has been > > using both GPIO _and_ internal HPD anyway. In case the native HPD > > doesn't work users are urged to switch to specifying the hpd-gpios > > property to the hdmi-connector device. > > In that case users would need to update their DTS/DTB, so that's an ABI > break. > > Please deprecate the property here (deprecated: true) and keep support > in the driver. I will expand the explanation for the need of the ABI break. Yes, it's a bad idea. No, it doesn't prevent the board from working. Yes, it needs to be done.
diff --git a/Documentation/devicetree/bindings/display/msm/hdmi.yaml b/Documentation/devicetree/bindings/display/msm/hdmi.yaml index 7e6f776a047a00851e3e1e27fec3dabeed5242fd..a5ff7045a14be3b8106b3edf0033a8028a684529 100644 --- a/Documentation/devicetree/bindings/display/msm/hdmi.yaml +++ b/Documentation/devicetree/bindings/display/msm/hdmi.yaml @@ -62,10 +62,6 @@ properties: core-vcc-supply: description: phandle to VCC supply regulator - hpd-gpios: - maxItems: 1 - description: hpd pin - '#sound-dai-cells': const: 1 @@ -178,7 +174,6 @@ examples: clocks = <&clk 61>, <&clk 72>, <&clk 98>; - hpd-gpios = <&msmgpio 72 GPIO_ACTIVE_HIGH>; core-vdda-supply = <&pm8921_hdmi_mvs>; hdmi-mux-supply = <&ext_3p3v>; pinctrl-names = "default", "sleep";
Supporting simultaneous check of native HPD and the external GPIO proved to be less stable than just native HPD. Drop the hpd-gpios from the bindings. This is not a breaking change, since the HDMI block has been using both GPIO _and_ internal HPD anyway. In case the native HPD doesn't work users are urged to switch to specifying the hpd-gpios property to the hdmi-connector device. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- Documentation/devicetree/bindings/display/msm/hdmi.yaml | 5 ----- 1 file changed, 5 deletions(-)