| Message ID | 20250314145440.11371-2-johan+linaro@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | abf89bc4bb09c16a53d693b09ea85225cf57ff39 |
| Headers | show |
| Series | arm64: dts: qcom: x1e: mark l12b and l15b always-on | expand |
On Fri, Mar 14, 2025 at 03:54:33PM +0100, Johan Hovold wrote: > The l12b and l15b supplies are used by components that are not (fully) > described (and some never will be) and must never be disabled. Which components? > > Mark the regulators as always-on to prevent them from being disabled, > for example, when consumers probe defer or suspend. > > Fixes: bd50b1f5b6f3 ("arm64: dts: qcom: x1e80100: Add Compute Reference Device") > Cc: stable@vger.kernel.org # 6.8 > Cc: Abel Vesa <abel.vesa@linaro.org> > Cc: Rajendra Nayak <quic_rjendra@quicinc.com> > Cc: Sibi Sankar <quic_sibis@quicinc.com> > Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > --- > arch/arm64/boot/dts/qcom/x1-crd.dtsi | 2 ++ > 1 file changed, 2 insertions(+) >
On Fri, Mar 14, 2025 at 06:36:19PM +0200, Dmitry Baryshkov wrote: > On Fri, Mar 14, 2025 at 03:54:33PM +0100, Johan Hovold wrote: > > The l12b and l15b supplies are used by components that are not (fully) > > described (and some never will be) and must never be disabled. > > Which components? https://lore.kernel.org/lkml/Z8gPaoqLiC_b2s3I@hovoldconsulting.com/ Johan
diff --git a/arch/arm64/boot/dts/qcom/x1-crd.dtsi b/arch/arm64/boot/dts/qcom/x1-crd.dtsi index 9e587dc57532..22ebcbe54e24 100644 --- a/arch/arm64/boot/dts/qcom/x1-crd.dtsi +++ b/arch/arm64/boot/dts/qcom/x1-crd.dtsi @@ -610,6 +610,7 @@ vreg_l12b_1p2: ldo12 { regulator-min-microvolt = <1200000>; regulator-max-microvolt = <1200000>; regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; + regulator-always-on; }; vreg_l13b_3p0: ldo13 { @@ -631,6 +632,7 @@ vreg_l15b_1p8: ldo15 { regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; + regulator-always-on; }; vreg_l16b_2p9: ldo16 {
The l12b and l15b supplies are used by components that are not (fully) described (and some never will be) and must never be disabled. Mark the regulators as always-on to prevent them from being disabled, for example, when consumers probe defer or suspend. Fixes: bd50b1f5b6f3 ("arm64: dts: qcom: x1e80100: Add Compute Reference Device") Cc: stable@vger.kernel.org # 6.8 Cc: Abel Vesa <abel.vesa@linaro.org> Cc: Rajendra Nayak <quic_rjendra@quicinc.com> Cc: Sibi Sankar <quic_sibis@quicinc.com> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Signed-off-by: Johan Hovold <johan+linaro@kernel.org> --- arch/arm64/boot/dts/qcom/x1-crd.dtsi | 2 ++ 1 file changed, 2 insertions(+)