| Message ID | 20250318-topic-more_dt_bindings_fixes-v1-4-cb36882ea9cc@oss.qualcomm.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | More more dt-bindings fixes for arm64/qcom | expand |
On Tue, Mar 18, 2025 at 07:35:17PM +0100, Konrad Dybcio wrote: > From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> > > The node has #clock-cells = <0>, as it only provides a single clock > output. > > This leads to a turbo sneaky bug, where the dt checker shows that we > have additional clocks in the array: > > clock-controller@c8c0000: clocks: [[3, 0], [39, 178], [156, 1], > [156, 0], [157, 1], [157, 0], [158], [0], [0], [0], [39, 184]] > is too long > > ..which happens due to dtc interpreting <&mdss_hdmi_phy 0> as > <&mdss_hdmi_phy>, <0> after taking cells into account. > > Remove the superfluous argument to both silence the warning and fix > the index-based lookup of subsequent entries in "clocks". > > Fixes: 2150c87db80c ("arm64: dts: qcom: msm8998: add HDMI nodes") > Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> > --- > arch/arm64/boot/dts/qcom/msm8998.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi index c2caad85c668df2ebe900bc560e39480ae03e353..8d5a8a3f2c12ee1bc742c7dad35368f140d81dd2 100644 --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi @@ -2794,7 +2794,7 @@ mmcc: clock-controller@c8c0000 { <&mdss_dsi0_phy 0>, <&mdss_dsi1_phy 1>, <&mdss_dsi1_phy 0>, - <&mdss_hdmi_phy 0>, + <&mdss_hdmi_phy>, <0>, <0>, <&gcc GCC_MMSS_GPLL0_DIV_CLK>;